🐛 Fix image properties propagation

[matofeder]

What this PR does / why we need it:

This PR contains a hot-fix that allows CreateOpts.properties definition via node-images.yaml as follows:

apiVersion: openstack.infrastructure.clusterstack.x-k8s.io/v1alpha1
openStackNodeImages:
  - createOpts:
      container_format: bare
      disk_format: qcow2
      name: ubuntu-capi-image-v1.29.9
      visibility: private
      properties:
        hw_disk_bus: "scsi"
        hw_rng_model: "virtio"
        hw_scsi_model: "virtio-scsi"
    url: ...

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #223

Special notes for your reviewer:

TODOs:

• squash commits
• include documentation
• add unit tests

[chess-knight]

LGTM

[Nils98Ar]

Thank you, looks good!

Is there a reason that hw_disk_bus the only property that you set in the unit tests?

[matofeder]

Is there a reason that hw_disk_bus the only property that you set in the unit tests?

There is no reason, I just arbitrarily picked some.

[jschoone]

Thanks for fixing it that fast @matofeder.
I can also confirm it works:

openstack image show ubuntu-capi-image-v1.31.4 -c properties -f json
{
  "properties": {
    ...
    "hw_disk_bus": "scsi",
    "hw_rng_model": "virtio",
    "hw_scsi_model": "virtio-scsi"
  }
}

[jschoone]

@matofeder can you create a release with this fix?

[matofeder]

@matofeder can you create a release with this fix?

sure, I will do that asap

[Nils98Ar]

Thanks @matofeder! I didn't expect this to be solved so quickly :)

[matofeder]

I tagged the latest main with v0.1.0-alpha.6, I believe that the github pipeline does the rest (release)..

[matofeder]

OK, I just had to click on the button and publish the release produced by the pipeline.

https://github.com/SovereignCloudStack/cluster-stack-provider-openstack/releases/tag/v0.1.0-alpha.6

let me know if you encounter any issues