CLI-60 CLI-61 Add integration tests and a harness

[kirill-knize-sonarsource]

No description provided.

[sonarqube-agent]

Remediation Agent Summary 📊

🤖 To review: The 4 issues found require manual fixes.

Issues requiring manual fix (4)

Quality	Issue	Status
Maintainability 🟠 Medium	Merge this if statement with the nested one. Why is this an issue? View this issue in SonarQube Cloud	Unresolved
Maintainability 🟡 Low	Unexpected negated condition. Why is this an issue? View this issue in SonarQube Cloud	Unresolved
Maintainability 🟡 Low	Prefer using nullish coalescing operator (`??`) instead of a ternary expression, as it is simpler to read. Why is this an issue? View this issue in SonarQube Cloud	Unresolved
Maintainability 🟡 Low	Unexpected negated condition. Why is this an issue? View this issue in SonarQube Cloud	Unresolved

Note

Help us improve the Agent!
Have a suggestion or found an issue? Share your feedback here.

[sonarqubecloud]

SonarQube reviewer guide

Summary: Adds a comprehensive integration testing harness with fake SonarQube/binaries servers, setup scripts, and resource downloads. Includes 400+ new integration tests covering auth, install, list, integrate, and analyze commands. Refactors build scripts, package.json test commands, and updates internal APIs.

Review Focus:

• Critical: New setup-integration-resources.ts — downloads real sonar-secrets binary & signature for offline testing. Verify download URL logic and PGP verification are correct.
• Critical: File-based keychain (SONAR_CLI_KEYCHAIN_FILE env var) — new feature for test isolation. Check src/lib/keychain.ts for createFileKeytar() implementation.
• Important: src/cli/commands/list.ts — resolveAuth() call moved after validation. Verify auth flow still works correctly.
• Important: Test harness design — 5 new helper files. Review fake-sonarqube-server.ts and cli-runner.ts for process spawning and loopback OAuth token delivery.
• Large: 600+ lines of integration tests in specs/. Spot-check a few test files to ensure assertions are realistic.

Start review at: `build-scripts/setup

💬 Please send your feedback

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud