Skip to content

SONARJAVA-6216 Optimize CI to reduce Repox bandwidth for sonar-java: add timeouts #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomasz-tylenda-sonarsource wants to merge 2 commits into
base: master
Choose a base branch
from
+41 −0
Open

SONARJAVA-6216 Optimize CI to reduce Repox bandwidth for sonar-java: add timeouts #5539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f15d1be
BUILD-XXXXX Optimize CI to reduce Repox bandwidth
tomasz-tylenda-sonarsource Mar 27, 2026
6feaf64
Undo paths-ignore
tomasz-tylenda-sonarsource Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/PrepareNextIteration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
Next-Iteration-Job:
name: Next Iteration Job
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
pull-requests: write
contents: write
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/PullRequestClosed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,15 @@ on:
pull_request:
types: [closed]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
PullRequestMerged_job:
name: Pull Request Merged
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
id-token: write
pull-requests: read
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/PullRequestCreated.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,15 @@ on:
pull_request:
types: ["opened"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
PullRequestCreated_job:
name: Pull Request Created
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
id-token: write
# For external PR, ticket should be created manually
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ReleasabilityCheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
releasability-status:
name: Releasability status
runs-on: github-ubuntu-latest-s
timeout-minutes: 30
permissions:
id-token: write
statuses: write
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/RequestReview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,15 @@ on:
pull_request:
types: ["review_requested"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Comment on lines 5 to +8
Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: cancel-in-progress: true with a per-PR concurrency group is unsafe for a review_requested trigger.

GitHub fires one review_requested event per reviewer added. If two reviewers are requested in quick succession (or as a batch), both runs land in the same concurrency group (workflow-pr_number), so the second run cancels the first mid-flight. Whatever this workflow does for the first reviewer (Jira transition, notification, etc.) is silently abandoned.

cancel-in-progress is appropriate when only the latest run matters (e.g. a lint check on every push). For event-driven workflows where each event represents a distinct real-world action, it loses data.

Either drop cancel-in-progress: true, or scope the group to the specific reviewer so concurrent runs for different reviewers don't collide:

concurrency:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number }}-${{ github.event.requested_reviewer.login || github.event.requested_team.slug }}
  cancel-in-progress: true
Suggested change
types: ["review_requested"]
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}-${{ github.event.requested_reviewer.login || github.event.requested_team.slug }}
cancel-in-progress: true
  • Mark as noise

cancel-in-progress: true

jobs:
RequestReview_job:
name: Request review
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
id-token: write
# For external PR, ticket should be moved manually
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/SubmitReview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ jobs:
SubmitReview_job:
name: Submit Review
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
id-token: write
pull-requests: read
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ToggleLockBranch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ jobs:
ToggleLockBranch_job:
name: Toggle lock branch
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
id-token: write
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/UpdateRuleMetadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on: workflow_dispatch
jobs:
rule-metadata-update:
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
id-token: write
contents: write
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/automated-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ on:
jobs:
release:
name: Release
timeout-minutes: 60
uses: SonarSource/release-github-actions/.github/workflows/automated-release.yml@v1
permissions:
statuses: read
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
build:
runs-on: github-ubuntu-latest-m # Public repo uses custom GitHub-hosted runner
name: Build
timeout-minutes: 60
permissions:
id-token: write # Required for Vault OIDC authentication
contents: write # Required for repository access and tagging
Expand Down Expand Up @@ -64,6 +65,7 @@ jobs:
- build
if: ${{ needs.build.outputs.deployed }}
runs-on: ${{ matrix.item.runner }}
timeout-minutes: 60
permissions:
id-token: write
contents: write
Expand Down Expand Up @@ -121,6 +123,7 @@ jobs:
- build
if: ${{ needs.build.outputs.deployed }}
runs-on: github-ubuntu-latest-m
timeout-minutes: 60
permissions:
id-token: write
contents: write
Expand Down Expand Up @@ -160,6 +163,7 @@ jobs:
- build
if: ${{ needs.build.outputs.deployed }}
runs-on: github-ubuntu-latest-m
timeout-minutes: 60
permissions:
id-token: write
contents: write
Expand Down Expand Up @@ -202,6 +206,7 @@ jobs:
- build
if: ${{ needs.build.outputs.deployed }}
runs-on: github-ubuntu-latest-l
timeout-minutes: 60
permissions:
id-token: write
contents: write
Expand Down Expand Up @@ -237,6 +242,7 @@ jobs:
- build
if: ${{ needs.build.outputs.deployed }}
runs-on: github-ubuntu-latest-m
timeout-minutes: 60
permissions:
id-token: write
contents: write
Expand Down Expand Up @@ -284,6 +290,7 @@ jobs:
- build
if: ${{ needs.build.outputs.deployed }}
runs-on: github-ubuntu-latest-m
timeout-minutes: 60
permissions:
id-token: write
contents: write
Expand Down Expand Up @@ -344,6 +351,7 @@ jobs:
name: Build and Unit Test on Windows
# No dependency on build step, because we do not need the build number.
runs-on: github-windows-latest-m
timeout-minutes: 60
permissions:
id-token: write # Required for Vault OIDC authentication
contents: write # Required for repository access and tagging
Expand Down Expand Up @@ -376,6 +384,7 @@ jobs:
if: ${{ needs.build.outputs.deployed }}
runs-on: github-ubuntu-latest-s # Public repo uses custom GitHub-hosted runners
name: Promote
timeout-minutes: 15
permissions:
id-token: write
contents: write
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/dogfood.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
dogfood_merge:
runs-on: github-ubuntu-latest-s
name: Update dogfood branch
timeout-minutes: 15
permissions:
id-token: write # required for SonarSource/vault-action-wrapper
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/mark-prs-stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
jobs:
stale:
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
permissions:
issues: write
pull-requests: write
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/pr-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@ on:
pull_request:
types: [closed]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
cleanup:
runs-on: github-ubuntu-latest-s # Public repo
timeout-minutes: 15
permissions:
actions: write
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/releasability.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
releasability-job:
name: Releasability check
runs-on: github-ubuntu-latest-s
timeout-minutes: 30
permissions:
id-token: write # required by SonarSource/vault-action-wrapper
contents: read # required by checkout
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
permissions:
id-token: write
contents: write
timeout-minutes: 60
uses: SonarSource/gh-action_release/.github/workflows/main.yaml@v6
with:
publishToBinaries: true
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/slack_notify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
if: >-
contains(fromJSON('["main", "master"]'), github.event.check_suite.head_branch) || startsWith(github.event.check_suite.head_branch, 'dogfood-') || startsWith(github.event.check_suite.head_branch, 'branch-')
runs-on: github-ubuntu-latest-s
timeout-minutes: 15
steps:
- name: Send Slack Notification
env:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unified-dogfooding.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
jobs:
unified-platform-dogfooding:
runs-on: github-ubuntu-latest-l
timeout-minutes: 60
name: Unified Platform Dogfooding
permissions:
id-token: write
Expand Down
Loading