SONARJAVA-6078 ScopedValue where result is ignored#5441
Draft
SONARJAVA-6078 ScopedValue where result is ignored#5441
Conversation
… lambdas, variable reassignment, multiple var same carrier...
Contributor
Author
|
I tried to cover as many edge cases as possible, but let's look at the following example : void A() {
var carrier = ScopedValue.where(SCOPED, "hello"); // FN carrier is not used
identity(carrier); // the rule consider carrier escapes from the function A with this call
}
ScopedValue.Carrier identity(ScopedValue.Carrier carrier) {
return carrier; // the rule consider carrier escapes from the function identity with this return
}I think the only way to implement this rule properly would be with CFG/symbolic execution |
…edValueWhereResultEdgeCasesSample.java
asya-vorobeva
requested changes
Feb 5, 2026
Contributor
asya-vorobeva
left a comment
asya-vorobeva
left a comment
There was a problem hiding this comment.
Sorry, but I can't validate such PR, too AI-generated. Common things that I'd recommend:
- try to reduce Sample files (a lot of things to test are redundant)
- try to restructure Check file, now it's too much boilerplate and very hard to maintain.
| } | ||
|
|
||
| void escapedCarrierFunctionCall() { | ||
| var carrier = ScopedValue.where(myScopedValue, "hello"); // ccompliant - the result escapes |
| ScopedValue.where(myScopedValue, "hello").get(myScopedValue); // Noncompliant | ||
| ScopedValue.where(myScopedValue, "hello").run(() -> { | ||
| }); // Compliant, the result is used immediately | ||
| ScopedValue.where(myScopedValue, "hello").where(ScopedValue.newInstance(), "hello").run(() -> { |
Contributor
There was a problem hiding this comment.
I don't like this example. The second chain call .where(ScopedValue.newInstance(), "hello") looks weird and should raise an issue (probably another rule?). We can't use such binding if it's unassigned. The same applies for myUnused2LevelCarrier below.
…ng, decompose isUsageValid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by : https://github.com/SonarSource/rspec/pull/6136