Skip to content

SONARJAVA-5340 FP on S1171 in anonymous classes #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asya-vorobeva merged 2 commits into from
Jan 29, 2026
Merged

SONARJAVA-5340 FP on S1171 in anonymous classes #5411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6acbed0
SONARJAVA-5340 FP on S1171 in anonymous classes
asya-vorobeva Jan 28, 2026
f249238
Test update
asya-vorobeva Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...hecks-test-sources/default/src/main/java/checks/NonStaticClassInitializerCheckSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ class NonStaticClassInitializerCheckSample {
static {
}

static class Inner {
{ // Noncompliant
}
}

{ // Noncompliant {{Move the contents of this initializer to a standard constructor or to field initializers.}}
//^
System.out.println();
Expand All @@ -14,7 +19,7 @@ public NonStaticClassInitializerCheckSample() {

new Runnable() {

{ // Noncompliant
{
System.out.println();
}

Expand Down
9 changes: 8 additions & 1 deletion java-checks/src/main/java/org/sonar/java/checks/NonStaticClassInitializerCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ public List<Tree.Kind> nodesToVisit() {

@Override
public void visitNode(Tree tree) {
reportIssue(((BlockTree) tree).openBraceToken(), "Move the contents of this initializer to a standard constructor or to field initializers.");
if (!isMemberOfAnonymousClass(tree)) {
reportIssue(((BlockTree) tree).openBraceToken(), "Move the contents of this initializer to a standard constructor or to field initializers.");
}
}

private static boolean isMemberOfAnonymousClass(Tree tree) {
Tree parent = tree.parent();
return parent.is(Tree.Kind.CLASS) && parent.parent() != null && parent.parent().is(Tree.Kind.NEW_CLASS);
}
}
Loading