Add runnable demo fixtures for the shipped UI surface#37
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8875e07d7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Makefile
Outdated
| demo-serve: | ||
| @printf "$(ARROW) Serving demos at http://localhost:8000/demos/\n" | ||
| @python3 -m http.server 8000 |
There was a problem hiding this comment.
Rebuild bundled assets before serving demo fixtures
Make demo-serve depend on assets. The new demos load ../static/sf/sf.css and ../static/sf/sf.js, but this target only starts python3 -m http.server. After make clean (which deletes both bundles in Makefile:228-231) the documented make demo-serve flow serves pages with 404s for the UI assets, and even without clean it can silently validate stale bundles after edits under css-src/ or js-src/ instead of the current sources.
Useful? React with 👍 / 👎.
8875e07 to
657ae9f
Compare
Closes #18.
Summary
make demo-servefor local troubleshooting