Skip to content

Add automated route and frontend coverage#19

Merged
blackopsrepl merged 1 commit intomainfrom
issue-1-test-coverage
Mar 23, 2026
Merged

Add automated route and frontend coverage#19
blackopsrepl merged 1 commit intomainfrom
issue-1-test-coverage

Conversation

@blackopsrepl
Copy link
Copy Markdown
Contributor

Summary

  • add Rust tests for embedded asset routing, MIME typing, and cache policy
  • add Node-based frontend tests for backend adapters, solver lifecycle behavior, and core component rendering
  • wire frontend tests into Makefile targets, CI workflows, and README guidance

Closes #1

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecf0b0ed00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +50 to +52
run: |
cargo test
node --test tests/*.test.js
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate release validation on the new frontend test suite

These lines add node --test to pull-request CI, but the release paths still stop at cargo test in .github/workflows/release.yml:50-51, .forgejo/workflows/release.yml:31-32, and the documented make pre-release target at Makefile:205-206. A regression in the shipped JavaScript can therefore still pass the actual release gate and be published from a tag without ever running the new suite, which defeats the coverage in the most important path.

Useful? React with 👍 / 👎.

@blackopsrepl blackopsrepl force-pushed the issue-1-test-coverage branch from ecf0b0e to de9944d Compare March 23, 2026 14:14
@blackopsrepl
Copy link
Copy Markdown
Contributor Author

Codex review was correct. After rebasing this branch onto current main, the new frontend suite was running in PR CI but not in .github/workflows/release.yml, .forgejo/workflows/release.yml, or make pre-release, so release validation could still publish a JavaScript regression. I updated those release paths to run the Node suite as part of the gate and reworked the new tests to match the current backend, tabs, and fake-DOM behavior on main. Local validation passed with cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test, and node --test tests/*.test.js.

@blackopsrepl blackopsrepl merged commit 47fef58 into main Mar 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add automated test coverage for Rust routes and frontend component behavior

1 participant