refactor: extract shared route-result assembly#24
Merged
blackopsrepl merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
route_snappedandroute_withstill duplicated the same node-path assembly logic for geometry and totals, androute_edge_snappedhad its own copy of the same path traversal work.This refactor extracts shared helpers for:
The shared helpers are reused by
route_snappedandroute_with, androute_edge_snappednow reuses the same geometry and path-metric helpers for its internal graph path portion.Validation
Fixes #11