Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the bundling/externalization strategy to improve browser/CDN usability and ensure build outputs keep consistent optimization settings, while updating documentation to reflect the new externalization split between UMD and ESM bundles.
Changes:
- Remove
@uvdsl/solid-oidc-client-browserexternals from the UMD builds so the UMD bundle no longer depends on those globals. - Preserve
commonConfig.optimizationsettings across all build variants by spreading them into each config’soptimizationblock. - Update README to describe which dependencies are externalized for UMD vs ESM bundles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| webpack.config.mjs | Moves auth-package externals to ESM-only and ensures optimization settings are consistently applied in all bundle variants. |
| README.md | Updates browser usage documentation to reflect the updated externalization behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+34
| The UMD bundles externalize `rdflib` only. | ||
|
|
||
| The ESM bundles externalize both `rdflib` and the auth library packages `@uvdsl/solid-oidc-client-browser` / `@uvdsl/solid-oidc-client-browser/core`. |
Member
Author
There was a problem hiding this comment.
I think we do not need to be so specific. No need to commit this suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing copilot reviews from previous PR #296