Skip to content

Solidos dependencies2 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bourgeoa merged 4 commits into from
Jun 24, 2026
+65 −70
Merged

Solidos dependencies2 #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
857cc82
listButton type as any
bourgeoa Jun 23, 2026
1d15ff5
auto update solidos dependencies
bourgeoa Jun 23, 2026
5fb5fa7
3.2.3-1
bourgeoa Jun 23, 2026
70ace02
chore: update solidos dependencies (dev: solid-logic@4.0.8-0 solid-ui…
github-actions[bot] Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ on:
workflow_dispatch:

jobs:
update-deps:
uses: SolidOS/solidos/.github/workflows/update-solidos-deps.yml@main
secrets: inherit

build:
needs: update-deps
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -57,6 +62,9 @@ jobs:

npm-publish-dev:
needs: build
permissions:
id-token: write
contents: read
uses: SolidOS/solidos/.github/workflows/publish-prerelease.yml@main
with:
node_version: 22
Expand Down
93 changes: 39 additions & 54 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 16 additions & 14 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "profile-pane",
"version": "3.2.3-0",
"version": "3.2.3-1",
"description": "A SolidOS compatible pane to display a personal profile page",
"sideEffects": [
"*.css"
Expand Down Expand Up @@ -38,7 +38,6 @@
"prepush": "npm test && npm run lint-fix && npm run typecheck && npm run typecheck-test",
"prepublishOnly": "npm run test && npm run build",
"preversion": "npm run lint && npm run typecheck && npm test",
"postpublish": "git push origin main --follow-tags",
"start": "webpack serve --config webpack.dev.config.mjs --open"
},
"keywords": [
Expand All @@ -57,16 +56,11 @@
"dependencies": {
"@solid-data-modules/contacts-rdflib": "^0.7.1",
"lit-html": "^3.3.3",
"pane-registry": "^3.1.2-test.0",
"pane-registry": "3.1.2-0",
"patch-package": "^8.0.1",
"qrcode": "^1.5.4",
"validate-color": "^2.2.4"
},
"peerDependencies": {
"rdflib": "^2.3.9",
"solid-logic": "^4.0.8-test.0",
"solid-ui": "^3.1.3-0"
},
"overrides": {
"rdflib": "$rdflib",
"solid-logic": "$solid-logic",
Expand All @@ -87,8 +81,8 @@
"babel-loader": "^10.1.1",
"babel-plugin-inline-import": "^3.0.0",
"babel-plugin-transform-import-meta": "^2.3.3",
"chat-pane": "^3.0.4-0",
"contacts-pane": "^3.2.1-1",
"chat-pane": "3.0.4-1",
"contacts-pane": "3.2.1-2",
"copy-webpack-plugin": "^14.0.0",
"css-loader": "^7.1.4",
"eslint": "^9.39.4",
Expand All @@ -98,15 +92,23 @@
"jest-fetch-mock": "^3.0.3",
"jsdom": "^29.1.1",
"node-polyfill-webpack-plugin": "^4.1.0",
"rdflib": "^2.3.9",
"solid-logic": "^4.0.8-test.0",
"solid-ui": "^3.1.3-0",
"rdflib": "2.3.9",
"solid-logic": "4.0.8-0",
"solid-ui": "3.1.3-5",
"style-loader": "^4.0.0",
"terser-webpack-plugin": "^5.6.0",
"ts-loader": "^9.5.7",
"typescript": "^6.0.3",
"webpack": "^5.106.2",
"webpack-cli": "^7.0.2",
"webpack-dev-server": "^5.2.4"
}
},
"solidosDependencies": [
"rdflib",
"solid-logic",
"solid-ui",
"pane-registry",
"chat-pane",
"contacts-pane"
]
}
4 changes: 2 additions & 2 deletions src/specialButtons/addContact/ContactCreationDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type ContactsButtonElement = SolidUIButtonElement

function setContactsListButtonSelected(button: Element, isSelected: boolean): void {
const listButton = button as ContactsButtonElement
listButton.selected = isSelected
;(listButton as any).selected = isSelected

@SharonStrats SharonStrats Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. Will create a ticket to not use selected.

if (isSelected) {
listButton.setAttribute('selected', '')
} else {
Expand All @@ -35,7 +35,7 @@ function setContactsListButtonSelected(button: Element, isSelected: boolean): vo
function isContactsListButtonSelected(button: Element | null): boolean {
if (!(button instanceof HTMLElement)) return false
const listButton = button as ContactsButtonElement
return listButton.selected || button.hasAttribute('selected')
return (listButton as any).selected || button.hasAttribute('selected')
}

function createContactsButtonElement(
Expand Down
Loading