Skip to content

Conversation

@HariRangarajan-Solace
Copy link
Collaborator

@HariRangarajan-Solace HariRangarajan-Solace commented Sep 21, 2025

Updated the Retail domain codelab for demonstrating a FE consumer in the order-service

✨ PR Description

Purpose: Update Solace Masterclass codelab to demonstrate frontend consumer configuration using Event Portal Designer instead of manual broker management.
Main changes:

  • Replaced manual queue creation through broker manager UI with Event Portal Designer configuration
  • Updated instructions for creating consumer queues with proper subscriptions in banking and retail domains
  • Simplified connection credential setup and application deployment instructions

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@solacecommunity-bot
Copy link
Collaborator

solacecommunity-bot commented Sep 21, 2025

Thanks for opening up a PR and contributing to our open source codelabs!

Review process Guidelines

Once the PR is opened, tag at least one Technical Reviewer

Technical Reviewer Responsibilities

  • Dry-run technical steps
  • Review technical positioning/messaging
  • Point out typos and potential formatting issues
  • Technical Reviewer(s): "Approve" or "Request Changes" by navigating to the Files changed tab and click on the "Review Changes" drop down
    Review Changes button

Post Technical Review

A member of the Developer Advocate Team will review overall structure and merge into master which will push it to production

@github-actions
Copy link

github-actions bot commented Sep 21, 2025

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR significantly restructures the masterclass documentation by replacing manual Java code implementation and broker configuration with Event Management API (EMA) based configuration. The changes improve user experience by providing GUI-based setup instructions.

2 issues detected:

🧾 Readability - Incomplete markdown formatting that could affect document rendering

Details: There appears to be an isolated bullet point marker that could cause markdown rendering issues or confusion for readers following the instructions.
File: markdown/solace-masterclass/solace-masterclass.md (883-883)

🐞 Bug - Image reference change may result in broken link if new file doesn't exist

Details: The image filename has been changed from "banking-domain-usecase.png" to "banking-domain-flowchart.png" without verification that the new file exists, which could result in broken documentation with missing images.
File: markdown/solace-masterclass/solace-masterclass.md (664-664)

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@gitstream-cm
Copy link

gitstream-cm bot commented Sep 21, 2025

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

…erclass-codelab-for-FE-consumer

# Conflicts:
#	markdown/solace-masterclass/solace-masterclass.md
@solacecommunity-bot
Copy link
Collaborator

solacecommunity-bot commented Sep 21, 2025

Thanks for opening up a PR and contributing to our open source codelabs!

Review process Guidelines

Once the PR is opened, tag at least one Technical Reviewer

Technical Reviewer Responsibilities

  • Dry-run technical steps
  • Review technical positioning/messaging
  • Point out typos and potential formatting issues
  • Technical Reviewer(s): "Approve" or "Request Changes" by navigating to the Files changed tab and click on the "Review Changes" drop down
    Review Changes button

Post Technical Review

A member of the Developer Advocate Team will review overall structure and merge into master which will push it to production

@HariRangarajan-Solace HariRangarajan-Solace merged commit e2ed893 into master Sep 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants