Skip to content

fix(proxy): repair request failure metadata migration#870

Open
Komzpa wants to merge 14 commits into
Soju06:mainfrom
Komzpa:repair/pr-821-request-log-failure-metadata
Open

fix(proxy): repair request failure metadata migration#870
Komzpa wants to merge 14 commits into
Soju06:mainfrom
Komzpa:repair/pr-821-request-log-failure-metadata

Conversation

@Komzpa
Copy link
Copy Markdown
Collaborator

@Komzpa Komzpa commented Jun 1, 2026

Summary

  • supersedes the closed-for-maintainer-edits repair path for fix(proxy): persist request failure metadata #821 while preserving the request failure metadata feature
  • keeps the new request log metadata migration on the current Alembic head chain after the current main migration merge revision
  • adds explicit OpenSpec coverage for request failure metadata and database migration ordering

Source PR

Tests

  • uv run pytest tests/unit/test_proxy_utils.py::test_write_request_log_persists_failure_metadata tests/unit/test_proxy_utils.py::test_request_log_failure_metadata_does_not_use_status_code_for_local_selection_failures -q
  • uv run ruff check app/db/alembic/versions/20260526_000000_add_request_log_failure_metadata.py app/db/alembic/versions/20260601_000000_merge_relative_availability_and_usage_raw_heads.py app/db/models.py app/modules/proxy/service.py tests/unit/test_proxy_utils.py
  • make migration-check
  • uv run openspec validate fix-request-log-failure-metadata --strict

@github-actions github-actions Bot added the db migration PR changes Alembic database migrations; maintainer must coordinate merge order label Jun 1, 2026
@Komzpa Komzpa force-pushed the repair/pr-821-request-log-failure-metadata branch from f079941 to bacadb7 Compare June 1, 2026 11:06
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f079941a92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/modules/proxy/service.py
@Soju06 Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026
@Soju06 Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026
@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented Jun 1, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29ec46fcc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/modules/proxy/service.py
@Komzpa Komzpa added the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026
@Komzpa Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026
@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented Jun 1, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 codex: ok [@codex review] says no issues found. db migration PR changes Alembic database migrations; maintainer must coordinate merge order

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants