feat(acc-ui): Group export to a unified dialog like export oauth#849
feat(acc-ui): Group export to a unified dialog like export oauth#849huzky-v wants to merge 7 commits into
Conversation
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63d3a98296
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48377d398d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c20c5706ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
DongwonTTuna
left a comment
There was a problem hiding this comment.
Code review notes (analysis only — no approval/changes-requested). Four points below: 2 medium dead-code cleanups and 2 low-severity notes.
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
# Conflicts: # frontend/src/features/accounts/hooks/use-accounts.test.ts
4ed4e18 to
bff887b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Hermes owner-review follow-up: I still see two merge-blocking issues on the current head (
Everything else I checked looked healthy: strict OpenSpec validation, focused backend/frontend tests, frontend typecheck/lint/build, and a local current-main merge probe all passed. Please fix or explicitly record the intended maintainer waiver/follow-up before merge. |
|
Folded into #865, which is now rebuilt on Current #865 status:
Closing this PR to keep the remaining merge queue |
Summary
Unifies the two separate Export buttons (Codex format and OpenCode auth) on the Accounts page into a single "Export" button that opens a modal with a format-mode dropdown selector. The backend gets a new combined endpoint
POST /api/accounts/{id}/export/authreturning structured tokens plus both Codex and OpenCode auth.json payloads in one response.Type of change
feat:— new user-facing feature or capabilityLinked issue:
OpenSpec
shape, SSE framing, OAuth flow) and preserves upstream-equivalent behavior
Change directory: openspec/changes/unify-auth-export/
Changes
POST /api/accounts/{id}/export/authendpoint returning structured tokens (id_token,access_token,refresh_token,expires_at_ms) plus bothcodexAuthJsonandopencodeAuthJsonobjects in one responseAccountAuthExportTokens,AccountAuthExportResponse,CodexAuthTokens,CodexAuthJsonschemas inapp/modules/accounts/schemas.pyexport_auth()service method combining logic fromexport_accountandexport_opencode_authAuthExportDialogcomponent (derived fromOpenCodeAuthExportDialog) with mode dropdown ("codex" / "opencode", default "codex"), Codex-mode token previews (id_token / access_token / refresh_token), context-aware auth.json block, and no-re-fetch mode switchingAccountAuthExportResponseSchemaand related sub-schemas inschemas.tsexportAccountAuth()API function andexportAuthMutationreplacingexportMutationandexportOpenCodeAuthMutationAccountActionscollapsed to single "Export" button;AccountDetailandAccountsPageprops simplifiedPOST /exportandPOST /export/opencode-authendpoints retained for backward compatibility, no frontend consumersTest plan
Checklist
<type>(<scope>)?: <subject>).uv run pre-commit run local-ci --hook-stage manual --all-filesor the relevantmake <target>subset locally.openspec validate --specspasses and/opsx:verifyis clean.