fix(proxy): fail over unary refresh connect errors by Komzpa · Pull Request #824 · Soju06/codex-lb

Komzpa · 2026-05-26T17:42:35Z

Summary

add a shared pre-visible unary freshness helper that retries another eligible account on transient refresh/connect failures
apply it to thread-goal, codex-control, transcribe, and file create/finalize flows
keep strict file-owner operations fail-closed instead of moving pinned file operations across accounts

Tests

uv run pytest tests/unit/test_proxy_utils.py::test_thread_goal_refresh_connection_reset_fails_over tests/unit/test_proxy_utils.py::test_codex_control_refresh_connection_reset_fails_over tests/unit/test_proxy_utils.py::test_transcribe_refresh_connection_reset_fails_over tests/unit/test_proxy_utils.py::test_files_create_refresh_connection_reset_fails_over tests/unit/test_proxy_utils.py::test_files_finalize_pinned_refresh_connection_reset_fails_closed -q
uv run pytest tests/unit/test_proxy_utils.py -q
uv run ruff check app/modules/proxy/service.py tests/unit/test_proxy_utils.py
uv run ruff format --check app/modules/proxy/service.py tests/unit/test_proxy_utils.py
uv run ty check app/modules/proxy/service.py tests/unit/test_proxy_utils.py
python -m compileall -q app/modules/proxy/service.py tests/unit/test_proxy_utils.py
git diff --check

No linked issue; addresses the owner-review unary refresh/connect failover gate in this PR.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1657afef1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-26T18:05:26Z

@codex review

chatgpt-codex-connector · 2026-05-26T18:05:41Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Komzpa · 2026-05-26T19:14:31Z

@codex review

chatgpt-codex-connector · 2026-05-26T19:14:39Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Soju06 · 2026-05-27T06:43:05Z

Merge-gate hold from owner review: the targeted unary refresh/connect failover code and focused tests look OK, but current repo gates are not satisfied.

Current-head Codex review is missing: the latest @codex review attempts hit Codex usage limits, and the PR has no 🤖 codex: ok label.
This changes observable proxy failover behavior but has no active OpenSpec change delta.
The PR body has no Fixes #... / Closes #... issue trace.

I did not find a code-level blocker in the targeted refresh/connect failover path, but I would hold merge until the above gates are addressed or explicitly waived.

chatgpt-codex-connector · 2026-05-27T06:43:14Z

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.

Soju06 · 2026-05-27T15:20:35Z

@codex review

chatgpt-codex-connector · 2026-05-27T15:20:42Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Komzpa · 2026-05-31T22:10:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a026345d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-05-31T23:07:55Z

@codex review

Komzpa · 2026-05-31T23:08:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0bdd45b61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-31T23:20:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a2ea9133a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T00:22:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0312a192e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T00:35:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 089189125f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T00:42:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df3b6da2f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T00:51:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0957f99b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T01:02:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b3d3b96ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T01:10:06Z

@codex review

chatgpt-codex-connector · 2026-06-01T01:14:40Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py Outdated

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 26, 2026

fix(proxy): fail over unary refresh connect errors

9c926b9

Komzpa force-pushed the fix/unary-refresh-connect-failover branch from 1657afe to 9c926b9 Compare May 26, 2026 17:50

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label May 26, 2026

Soju06 added the hermes: needs-followup Hermes left a blocker/comment that needs follow-up observation label May 27, 2026

docs(openspec): add unary refresh failover delta

8a02634

chatgpt-codex-connector Bot reviewed May 31, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py

Comment thread app/modules/proxy/service.py Outdated

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 31, 2026

fix(proxy): fail over transient unary upstream calls

d0bdd45

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label May 31, 2026

chatgpt-codex-connector Bot reviewed May 31, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py

Comment thread app/modules/proxy/service.py Outdated

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 31, 2026

fix(proxy): attribute unary failover failures once

6a2ea91

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label May 31, 2026

chatgpt-codex-connector Bot reviewed May 31, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py Outdated

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 31, 2026

fix(proxy): record unary fallback freshness failures

f0312a1

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label May 31, 2026

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

fix(proxy): avoid unary failover after body reads

0891891

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/core/clients/proxy.py

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

fix(proxy): keep status read failures non-replayable

df3b6da

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

fix(proxy): attribute unary fallback call failures

a0957f9

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

fix(proxy): fail over refresh transport errors

9b3d3b9

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/modules/proxy/service.py

Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

fix(proxy): preserve fallback refresh transport failures

8619751

Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label Jun 1, 2026

Komzpa added 🤖 codex: ok [@codex review] says no issues found. and removed hermes: needs-followup Hermes left a blocker/comment that needs follow-up observation labels Jun 1, 2026

Conversation

Komzpa commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 26, 2026

Uh oh!

Komzpa commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 26, 2026

Uh oh!

Soju06 commented May 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 27, 2026

Uh oh!

Soju06 commented May 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 27, 2026

Uh oh!

Komzpa commented May 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Soju06 commented May 31, 2026

Uh oh!

Komzpa commented May 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Komzpa commented May 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented May 26, 2026 •

edited

Loading