Skip to content

fix(proxy): preserve reset-window fallback ordering#779

Closed
Komzpa wants to merge 10 commits into
mainfrom
fix/pr-644-reset-window-preference
Closed

fix(proxy): preserve reset-window fallback ordering#779
Komzpa wants to merge 10 commits into
mainfrom
fix/pr-644-reset-window-preference

Conversation

@Komzpa
Copy link
Copy Markdown
Collaborator

@Komzpa Komzpa commented May 22, 2026

Supersedes #644 because the repaired fork head is not receiving the required CI suite.

What changed:

  • keeps sub-day precision when secondary reset preference falls back to primary reset timestamps
  • keeps normal secondary reset bucketing unchanged
  • keeps the reset-window migration merged with the current DB head

Local verification:

  • uv run ruff check app/core/balancer/logic.py tests/unit/test_load_balancer.py
  • uv run ty check app/core/balancer/logic.py tests/unit/test_load_balancer.py
  • uv run pytest tests/unit/test_load_balancer.py::test_select_account_secondary_reset_fallback_uses_primary_subday_precision tests/unit/test_load_balancer.py::test_select_account_primary_reset_preference_uses_subday_precision tests/unit/test_load_balancer.py::test_select_account_prefers_lower_secondary_used_with_same_reset_bucket -q

Replaces the currently blocked #644 head.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f759e6451

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/core/balancer/logic.py Outdated
@Soju06 Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 22, 2026
@Soju06 Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label May 22, 2026
@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented May 22, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa
Copy link
Copy Markdown
Collaborator Author

Komzpa commented May 23, 2026

Closing as duplicate of older PR #644. The branch points at the same fixed head, so review/merge should continue there.

@Komzpa Komzpa closed this May 23, 2026
@Komzpa Komzpa deleted the fix/pr-644-reset-window-preference branch May 23, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 codex: ok [@codex review] says no issues found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants