feat(settings): split sticky reallocation thresholds by Komzpa · Pull Request #659 · Soju06/codex-lb

Komzpa · 2026-05-15T14:38:50Z

Draft split from #567.

Purpose

Split sticky reallocation pressure into primary and secondary budget thresholds.
Keep the old stickyReallocationBudgetThresholdPct field for compatibility while adding primary/secondary settings.
Make sticky reallocation use the primary threshold for the short window and the secondary threshold for the 7-day window.

Validation

Head: 764596008d5d5a5dd64f1d7ac235ddaf73651cf0.
Exact-head GitHub CI is green.
Fresh @codex review completed for 764596008d5d5a5dd64f1d7ac235ddaf73651cf0.
Local checks passed: ruff format/check, ty, focused pytest for settings/sticky threshold behavior, SQLite migration policy, focused frontend eslint/typecheck/vitest.

Relationship

Replaces the sticky-threshold portion of feat(proxy): add opportunistic traffic class #567.
feat(proxy): add opportunistic traffic class #567 remains Draft and should not be merged as one large PR.
This is the first PR in the dependent split chain; feat(proxy): add opportunistic traffic class core #657 is based on this branch for review/CI stackability.

Komzpa · 2026-05-15T14:39:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5707abaa5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-15T14:53:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 764596008d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-16T01:47:00Z

@codex review

chatgpt-codex-connector · 2026-05-16T01:50:57Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-16T10:36:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bc94eeb6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-16T10:42:36Z

@codex review

Komzpa · 2026-05-16T10:46:00Z

@codex review

chatgpt-codex-connector · 2026-05-16T10:50:36Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-16T10:51:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6346022952

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-05-16T19:23:18Z

@codex review

Soju06 · 2026-06-01T15:36:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 326e239184

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-01T16:02:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 957dff3d40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soju06 · 2026-06-01T17:31:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0aa26aac8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T17:44:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d40cec5f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T17:52:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b08dba3fcd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-01T17:59:06Z

@codex review

chatgpt-codex-connector · 2026-06-01T18:03:35Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Komzpa · 2026-06-02T02:50:14Z

Folded into #716.

#716 is the surviving main-based routing/quota branch for this bucket. It includes the routing/quota changes from this PR, has current-head CI green, and has a clean current-head Codex review, so this separate PR can be closed to keep the queue reviewable.

Komzpa mentioned this pull request May 15, 2026

Tested live aggregate stack and suggested merge order #554

Open

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread app/modules/settings/api.py Outdated

Komzpa force-pushed the split/567-sticky-thresholds-independent branch from f5707ab to 7645960 Compare May 15, 2026 14:45

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread app/modules/settings/api.py Outdated

Komzpa mentioned this pull request May 15, 2026

feat(proxy): add opportunistic traffic class core #657

Merged

Komzpa marked this pull request as ready for review May 15, 2026 17:03

Komzpa mentioned this pull request May 16, 2026

feat(proxy): add opportunistic traffic class #567

Closed

Komzpa force-pushed the split/567-sticky-thresholds-independent branch from 6346022 to 1bc94ee Compare May 16, 2026 10:36

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Comment thread app/db/alembic/versions/20260515_020000_add_split_sticky_budget_thresholds.py Outdated

Komzpa force-pushed the split/567-sticky-thresholds-independent branch from 1bc94ee to 6346022 Compare May 16, 2026 10:41

Komzpa force-pushed the split/567-sticky-thresholds-independent branch 2 times, most recently from 0f08947 to 6346022 Compare May 16, 2026 10:45

Komzpa force-pushed the split/567-sticky-thresholds-independent branch from 6346022 to 0f08947 Compare May 16, 2026 10:49

Komzpa force-pushed the split/567-sticky-thresholds-independent branch from 0f08947 to 6346022 Compare May 16, 2026 10:51

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Comment thread app/modules/settings/api.py Outdated

Komzpa mentioned this pull request May 16, 2026

feat(settings): combine manual routing and sticky thresholds #675

Closed

Komzpa added 🤖 codex: ok [@codex review] says no issues found. 🤖 codex: needs work [@codex review] raised an issue and removed 🤖 codex: ok [@codex review] says no issues found. 🤖 codex: needs work [@codex review] raised an issue labels May 16, 2026

Komzpa added 8 commits June 1, 2026 18:53

fix(settings): keep threshold fallbacks typed

fcd33e8

fix(db): merge sticky thresholds and bridge migration heads

fa47fd0

fix(proxy): apply split thresholds to codex control fallback

3e1379b

fix(settings): finish split sticky threshold review fixes

86a6133

fix(settings): allow unchanged split threshold saves

81d82a5

fix(proxy): apply split secondary threshold globally

0054099

fix(settings): format split threshold update guard

92dd9ed

fix(proxy): keep sticky pool exhaustion split-threshold aware

f367765

Komzpa force-pushed the split/567-sticky-thresholds-independent branch from f13aee3 to 743b694 Compare June 1, 2026 15:00

fix(db): chain split threshold migration after account aliases

6b1a4e2

Komzpa force-pushed the split/567-sticky-thresholds-independent branch from 743b694 to 6b1a4e2 Compare June 1, 2026 15:04

test(frontend): include split sticky thresholds in settings payloads

326e239

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/modules/proxy/load_balancer.py

Comment thread app/modules/proxy/load_balancer.py Outdated

fix(proxy): scope split secondary threshold to sticky routing

957dff3

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/modules/settings/schemas.py

docs(openspec): cover split sticky thresholds

0aa26aa

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/modules/proxy/load_balancer.py Outdated

Comment thread openspec/changes/add-split-sticky-reallocation-thresholds/specs/frontend-architecture/spec.md

fix(proxy): scope sticky split thresholds

0d40cec

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread frontend/src/features/settings/payload.ts

fix(settings): align legacy sticky threshold saves

b08dba3

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread app/db/alembic/versions/20260515_020000_add_split_sticky_budget_thresholds.py

fix(db): backfill secondary sticky threshold

4570600

Conversation

Komzpa commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Validation

Relationship

Uh oh!

Komzpa commented May 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented May 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 16, 2026

Uh oh!

Komzpa commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented May 16, 2026

Uh oh!

Komzpa commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 16, 2026

Uh oh!

Komzpa commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented May 16, 2026

Uh oh!

Soju06 commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Soju06 commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Soju06 commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Komzpa commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Komzpa commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Komzpa commented May 15, 2026 •

edited

Loading