Skip to content

Keep credit-backed accounts usable and show live credits in the dashboard#254

Closed
mws-weekend-projects wants to merge 3 commits into
Soju06:mainfrom
mws-weekend-projects:pr/credits-aware-quota-and-dashboard
Closed

Keep credit-backed accounts usable and show live credits in the dashboard#254
mws-weekend-projects wants to merge 3 commits into
Soju06:mainfrom
mws-weekend-projects:pr/credits-aware-quota-and-dashboard

Conversation

@mws-weekend-projects
Copy link
Copy Markdown
Contributor

  • This keeps accounts selectable when weekly quota is exhausted but credits are still available.
  • It also shows the live credit balance in the dashboard and handles unassigned request log rows.

@Komzpa
Copy link
Copy Markdown
Collaborator

Komzpa commented May 16, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6090d45b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

requestedAt: z.string().datetime({ offset: true }),
accountId: z.string(),
accountId: z.string().nullable(),
apiKeyName: z.string().nullable(),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Make apiKeyName optional in request log schema

RequestLogSchema now requires an apiKeyName property (z.string().nullable()), but the current backend request-log contract does not emit that field (see RequestLogEntry/to_request_log_entry), so parsing /api/request-logs responses will fail whenever rows omit apiKeyName, breaking the request log view despite otherwise valid data. Use .optional() (or add server-side emission) to keep the client compatible.

Useful? React with 👍 / 👎.

@Komzpa Komzpa added 🤖 codex: needs work [@codex review] raised an issue 🤖 codex: ok [@codex review] says no issues found. and removed 🤖 codex: needs work [@codex review] raised an issue 🤖 codex: ok [@codex review] says no issues found. labels May 16, 2026
@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented May 21, 2026

Maintainer cleanup: closing this as stale / no longer merge-ready against the current main.

This PR has been open across substantial main-branch churn and is currently carrying at least one stale signal (conflicts/blocked or failing checks, outstanding codex: needs work, draft/old branch state, or overlap with newer/current implementation). Keeping it open is making the PR queue harder to reason about.

If the change is still needed, please open a fresh, focused PR rebased on current main with green CI and a clean Codex review.

@Soju06 Soju06 closed this May 21, 2026
@Komzpa Komzpa added needs rebase Needs rebase or conflict repair against current main stale No response from reporter; scheduled for close labels May 21, 2026
@Komzpa
Copy link
Copy Markdown
Collaborator

Komzpa commented May 21, 2026

Revived on a maintainer-owned branch as #767 because this PR head has maintainerCanModify=false and cannot be updated here. Keeping credit to the original implementation in the replacement PR.

@Komzpa Komzpa added superseded Replaced by another PR, issue track, or merged implementation and removed 🤖 codex: needs work [@codex review] raised an issue needs rebase Needs rebase or conflict repair against current main labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale No response from reporter; scheduled for close superseded Replaced by another PR, issue track, or merged implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants