Keep credit-backed accounts usable and show live credits in the dashboard#254
Conversation
mws-weekend-projects
commented
Mar 23, 2026
- This keeps accounts selectable when weekly quota is exhausted but credits are still available.
- It also shows the live credit balance in the dashboard and handles unassigned request log rows.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6090d45b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requestedAt: z.string().datetime({ offset: true }), | ||
| accountId: z.string(), | ||
| accountId: z.string().nullable(), | ||
| apiKeyName: z.string().nullable(), |
There was a problem hiding this comment.
Make apiKeyName optional in request log schema
RequestLogSchema now requires an apiKeyName property (z.string().nullable()), but the current backend request-log contract does not emit that field (see RequestLogEntry/to_request_log_entry), so parsing /api/request-logs responses will fail whenever rows omit apiKeyName, breaking the request log view despite otherwise valid data. Use .optional() (or add server-side emission) to keep the client compatible.
Useful? React with 👍 / 👎.
|
Maintainer cleanup: closing this as stale / no longer merge-ready against the current This PR has been open across substantial main-branch churn and is currently carrying at least one stale signal (conflicts/blocked or failing checks, outstanding If the change is still needed, please open a fresh, focused PR rebased on current |
|
Revived on a maintainer-owned branch as #767 because this PR head has maintainerCanModify=false and cannot be updated here. Keeping credit to the original implementation in the replacement PR. |