-
Notifications
You must be signed in to change notification settings - Fork 2
fix: include namespace in deduplicated purl construction #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3a8b3e8
fix: include namespace in deduplicated purl construction
dacoburn 14d4a4c
Added in templates
dacoburn e503f0f
Update .github/PULL_REQUEST_TEMPLATE/bug-fix.md
dacoburn 9f06607
Merge branch 'main' into doug/fix-dedupe-logic-for-artifacts
dacoburn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Click on the "Preview" tab and select appropriate PR template: | ||
|
|
||
| [New Feature](?expand=1&template=feature.md) | ||
| [Bug Fix](?expand=1&template=bug-fix.md) | ||
| [Improvement](?expand=1&template=improvement.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <!--Description: Briefly describe the bug and its impact. If there's a related Linear ticket or Sentry issue, link it here. ⬇️ --> | ||
|
|
||
| ## Root Cause | ||
| <!-- Concise explanation of what caused the bug ⬇️ --> | ||
|
|
||
|
|
||
|
|
||
| ## Fix | ||
| <!-- Explain how your changes address the bug ⬇️ --> | ||
|
|
||
| ## Public Changelog | ||
| <!-- Write a changelog message between comment tags if this should be included in the public product changelog, Leave blank otherwise. --> | ||
|
|
||
| <!-- changelog ⬇️--> | ||
| N/A | ||
| <!-- /changelog ⬆️ --> | ||
|
|
||
|
|
||
| <!-- TEMPLATE TYPE DON'T REMOVE: python-sdk-template-bug-fix --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <!-- Description: Briefly describe the new feature you're introducing ⬇️ --> | ||
|
|
||
|
|
||
| ## Why? | ||
| <!-- Explain the motivation behind this feature and its expected benefits ⬇️ --> | ||
|
|
||
|
|
||
|
|
||
| ## Public Changelog | ||
| <!-- Write a changelog message between comment tags if this should be included in the public product changelog. --> | ||
|
|
||
| <!-- changelog ⬇️--> | ||
| N/A | ||
| <!-- /changelog ⬆️ --> | ||
|
|
||
| <!-- TEMPLATE TYPE DON'T REMOVE: python-sdk-template-feature --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <!-- Description: Briefly describe the code improvement you're making. This could include things like lint fixes, adding monitoring dashboards, optimizing scripts, refactoring, etc. ⬇️ --> | ||
|
|
||
| ## Public Changelog | ||
| <!-- Write a changelog message between comment tags if this should be included in the public product changelog. --> | ||
|
|
||
| <!-- changelog ⬇️--> | ||
| N/A | ||
| <!-- /changelog ⬆️ --> | ||
|
|
||
| <!-- TEMPLATE TYPE DON'T REMOVE: python-sdk-template-improvement --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "3.0.0" | ||
| __version__ = "3.0.2" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.