stdio:inherit when using Coana for fixes

[mtorp]

Inherit stdio when running auto fixes using the Coana CLI. Made this change since it is otherwise difficult to tell if the Coana CLI is making progress.

[claude]

Claude finished @mtorp's task —— View job

---

Code Review Complete ✅

Todo List:

• Read repository guidelines (CLAUDE.md - file not found, using general guidelines)
• Examine the changed file: src/commands/fix/coana-fix.mts
• Analyze code quality and best practices
• Check for potential bugs or issues
• Review performance and security implications
• Provide actionable feedback and suggestions

---

Review Summary

This PR adds stdio: 'inherit' to three spawnCoana calls in the coanaFix function to improve visibility of Coana CLI progress. The change is well-implemented and addresses a real UX issue.

Code Quality: ✅ Good

Strengths:

• Consistent application: The change is applied to all three spawnCoana calls in src/commands/fix/coana-fix.mts:108, src/commands/fix/coana-fix.mts:128, and src/commands/fix/coana-fix.mts:181
• Minimal and focused: Only changes what's necessary to solve the problem
• Proper integration: The stdio option is correctly passed through the existing options pattern

Code locations analyzed:

• Lines 108, 128, 181: All three calls now include stdio: 'inherit' in their options objects
• The shadowBin function at src/shadow/npm/bin.mts:72-81 properly handles string stdio values by converting them to arrays and preserving IPC communication

Technical Analysis: ✅ Sound

Implementation details:

• The stdio: 'inherit' option allows child process output to be displayed directly to the user's terminal
• The shadowBin function correctly processes this option by converting it to ['inherit', 'inherit', 'inherit', 'ipc']
• IPC communication is preserved for internal Socket CLI coordination

No issues identified:

• ✅ No breaking changes to existing functionality
• ✅ No security implications (stdio inheritance is safe in this CLI context)
• ✅ No performance impact (stdio redirection has negligible overhead)
• ✅ No compatibility issues (Node.js stdio options are well-supported)

User Experience: ✅ Significant Improvement

Before: Users saw no output during potentially long-running Coana operations, making it unclear if the process was stuck or progressing.

After: Users can see real-time progress output from the Coana CLI, providing better feedback and confidence that the operation is working.

Architecture Considerations: ✅ Appropriate

The change maintains the existing pattern where:

• Spinner control remains with the Socket CLI
• Output visibility is improved without disrupting the CLI's own logging
• The change is isolated to the specific use case where progress visibility is most valuable

Recommendation: ✅ APPROVE

This is a well-targeted improvement that solves a legitimate UX problem with minimal risk. The implementation is clean, consistent, and follows existing patterns in the codebase.

No changes needed - the PR is ready for merge.

---