Skip to content

upload all manifests files when running socket scan create --reach #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdalton merged 1 commit into from
Aug 26, 2025
Merged

upload all manifests files when running socket scan create --reach #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/commands/scan/handle-create-new-scan.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,14 @@ export async function handleCreateNewScan({

logger.success('Reachability analysis completed successfully')

scanPaths = reachResult.data?.reachabilityReport
? [reachResult.data.reachabilityReport]
: []
scanPaths = [
...packagePaths.filter(
// Ensure the .socket.facts.json isn't duplicated in case it happened
// to be in the scan folder before the analysis was run.
p => !p.endsWith(constants.DOT_SOCKET_DOT_FACTS_JSON),
),
reachResult.data?.reachabilityReport,
]
tier1ReachabilityScanId = reachResult.data?.tier1ReachabilityScanId
}

Expand Down
3 changes: 2 additions & 1 deletion src/commands/scan/perform-reachability-analysis.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ export async function performReachabilityAnalysis(

const wasSpinning = !!spinner?.isSpinning

// Exclude .socket.facts.json from upload.
// Exclude any .socket.facts.json files that happen to be
// in the scan folder before the analysis was run.
const filepathsToUpload = packagePaths.filter(
p => !p.endsWith(constants.DOT_SOCKET_DOT_FACTS_JSON),
)
Expand Down
Loading