Conversation
Comment on lines
+201
to
+206
| packagePaths = packagePaths.filter( | ||
| p => | ||
| /* Exclude DOT_SOCKET_DOT_FACTS_JSON from previous runs */ !p.includes( | ||
| constants.DOT_SOCKET_DOT_FACTS_JSON, | ||
| ), | ||
| ) |
Contributor
There was a problem hiding this comment.
The parameter packagePaths is being reassigned without proper declaration. According to the Google TypeScript Style Guide, variables requiring reassignment should use let instead of const. Either declare the parameter as let packagePaths in the function signature, or create a new variable with let for the filtered result to avoid reassigning the parameter directly.
Suggested change
| packagePaths = packagePaths.filter( | |
| p => | |
| /* Exclude DOT_SOCKET_DOT_FACTS_JSON from previous runs */ !p.includes( | |
| constants.DOT_SOCKET_DOT_FACTS_JSON, | |
| ), | |
| ) | |
| const filteredPackagePaths = packagePaths.filter( | |
| p => | |
| /* Exclude DOT_SOCKET_DOT_FACTS_JSON from previous runs */ !p.includes( | |
| constants.DOT_SOCKET_DOT_FACTS_JSON, | |
| ), | |
| ) | |
Spotted by Diamond (based on custom rule: Custom rules)
Is this helpful? React 👍 or 👎 to let us know.
jdalton
reviewed
Aug 11, 2025
jdalton
reviewed
Aug 11, 2025
jdalton
reviewed
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.