Skip to content

Improve default org feedback / CTA #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvdz merged 1 commit into from
Jun 16, 2025
Merged

Improve default org feedback / CTA #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/commands/analytics/cmd-analytics.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)
expect(code, 'explicit help should exit with code 0').toBe(0)
Expand All @@ -72,8 +72,9 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>

\\x1b[31m\\xd7\\x1b[39m \\x1b[41m\\x1b[1m\\x1b[37m Input error: \\x1b[39m\\x1b[22m\\x1b[49m \\x1b[1mPlease review the input requirements and try again

- The time filter must either be 7, 30 or 90 (\\x1b[32mok\\x1b[39m)
Expand Down Expand Up @@ -105,8 +106,9 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>

\\x1b[31m\\xd7\\x1b[39m \\x1b[41m\\x1b[1m\\x1b[37m Input error: \\x1b[39m\\x1b[22m\\x1b[49m \\x1b[1mPlease review the input requirements and try again

- Legacy flags are no longer supported. See v1 migration guide. (\\x1b[31mreceived legacy flags\\x1b[39m)
Expand All @@ -129,7 +131,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand All @@ -147,7 +149,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand All @@ -165,8 +167,9 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>

\\x1b[31m\\xd7\\x1b[39m \\x1b[41m\\x1b[1m\\x1b[37m Input error: \\x1b[39m\\x1b[22m\\x1b[49m \\x1b[1mPlease review the input requirements and try again

- When scope=repo, repo name should be the second argument (\\x1b[31mmissing\\x1b[39m)
Expand Down Expand Up @@ -196,7 +199,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand All @@ -214,7 +217,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand All @@ -232,7 +235,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand All @@ -250,7 +253,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand All @@ -276,8 +279,9 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>

\\x1b[31m\\xd7\\x1b[39m \\x1b[41m\\x1b[1m\\x1b[37m Input error: \\x1b[39m\\x1b[22m\\x1b[49m \\x1b[1mPlease review the input requirements and try again

- Legacy flags are no longer supported. See v1 migration guide. (\\x1b[31mreceived legacy flags\\x1b[39m)
Expand Down Expand Up @@ -307,7 +311,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand All @@ -333,7 +337,7 @@ describe('socket analytics', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket analytics\`, cwd: <redacted>"
`)

Expand Down
16 changes: 9 additions & 7 deletions src/commands/audit-log/cmd-audit-log.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('socket audit-log', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket audit-log\`, cwd: <redacted>"
`)

Expand All @@ -76,11 +76,12 @@ describe('socket audit-log', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket audit-log\`, cwd: <redacted>
\\x1b[33m\\u203c\\x1b[39m Missing the org slug and no --org flag set. Trying to auto-discover the org now...
\\x1b[34mi\\x1b[39m Note: you can set the default org slug to prevent this issue. You can also override all that with the --org flag.
\\x1b[33m\\u203c\\x1b[39m Unable to determine the target org. Trying to auto-discover it now...
\\x1b[34mi\\x1b[39m Note: you can run \`socket login\` to set a default org. You can also override it with the --org flag.
\\x1b[31m\\xd7\\x1b[39m Skipping auto-discovery of org in dry-run mode

\\x1b[31m\\xd7\\x1b[39m \\x1b[41m\\x1b[1m\\x1b[37m Input error: \\x1b[39m\\x1b[22m\\x1b[49m \\x1b[1mPlease review the input requirements and try again

- Org name by default setting, --org, or auto-discovered (\\x1b[31mmissing\\x1b[39m)
Expand Down Expand Up @@ -108,8 +109,9 @@ describe('socket audit-log', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>, org: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket audit-log\`, cwd: <redacted>

\\x1b[31m\\xd7\\x1b[39m \\x1b[41m\\x1b[1m\\x1b[37m Input error: \\x1b[39m\\x1b[22m\\x1b[49m \\x1b[1mPlease review the input requirements and try again

- Legacy flags are no longer supported. See v1 migration guide. (\\x1b[31mreceived legacy flags\\x1b[39m)
Expand All @@ -135,7 +137,7 @@ describe('socket audit-log', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>, org: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket audit-log\`, cwd: <redacted>"
`)

Expand All @@ -160,7 +162,7 @@ describe('socket audit-log', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, --org: forcedorg
|_____|___|___|_,_|___|_|.dev | Command: \`socket audit-log\`, cwd: <redacted>"
`)

Expand Down
4 changes: 2 additions & 2 deletions src/commands/ci/cmd-ci.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('socket ci', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket ci\`, cwd: <redacted>"
`)

Expand All @@ -61,7 +61,7 @@ describe('socket ci', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket ci\`, cwd: <redacted>"
`)

Expand Down
5 changes: 2 additions & 3 deletions src/commands/cli.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ describe('socket root command', async () => {
Usage
$ socket <command>


All commands have their own --help page

Main commands
Expand Down Expand Up @@ -72,7 +71,7 @@ describe('socket root command', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket\`, cwd: <redacted>"
`)

Expand All @@ -92,7 +91,7 @@ describe('socket root command', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket\`, cwd: <redacted>"
`)

Expand Down
4 changes: 2 additions & 2 deletions src/commands/config/cmd-config-auto.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('socket config auto', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket config auto\`, cwd: <redacted>"
`)

Expand Down Expand Up @@ -82,7 +82,7 @@ describe('socket config auto', async () => {
"
_____ _ _ /---------------
| __|___ ___| |_ ___| |_ | Socket.dev CLI ver <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token set: <redacted>
|__ | * | _| '_| -_| _| | Node: <redacted>, API token: <redacted>, org: <redacted>
|_____|___|___|_,_|___|_|.dev | Command: \`socket config auto\`, cwd: <redacted>"
`)

Expand Down
Loading