Add --report to socket scan create, to immediately generate a report#408
Merged
Add --report to socket scan create, to immediately generate a report#408
Conversation
jdalton
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old report workflow, attached to
socket ci, is to do create a report and then ask for the results in a report view. While you could do the same in the scan creation flow, it would require some slightly awkward shell script to handle the json result and fire a report request etc. Anyways,--reporttakes care of that.The only concern is a timeout from the server while waiting for the scan to complete...
Also clarified flags desc for pendingHead and defaultBranch a bit.
Fixed a bug with
defaultOrg(nobody uses this yet) with the suggestion flow.Added support for
--jsonand--markdownin thesocket scan createflow. A bit superficial but it does what it should do.