Skip to content

Validate apiToken on input and threatfeed fixes#397

Merged
jdalton merged 1 commit intomainfrom
validate_apitoken
Apr 1, 2025
Merged

Validate apiToken on input and threatfeed fixes#397
jdalton merged 1 commit intomainfrom
validate_apitoken

Conversation

@pvdz
Copy link
Contributor

@pvdz pvdz commented Apr 1, 2025

  • make apiToken reject command at input validation, rather than throw a hard error. removed the hard error for it; just let setupSdk() fail over it if it does reach there anyways.
  • update the input validation to also check for the json+markdown flag
  • change the input validation schema to accept a nook flag rather than hide, to prevent repeated expressions. nook is not-ok, indicating to print the message only when the test fails
  • harden the threat-feed logic in case of errors. try to make sure it never infinite-loop-freezes the terminal. make sure the escape keys are bound to the screen before anything else.

@pvdz pvdz requested a review from jdalton April 1, 2025 10:27
@jdalton jdalton merged commit 560441e into main Apr 1, 2025
4 checks passed
@jdalton jdalton deleted the validate_apitoken branch April 1, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants