Conversation
jdalton
approved these changes
Mar 26, 2025
jdalton
pushed a commit
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's migrate
apiKeyout of the config.After this PR, when the CLI loads the config, if it see the
apiKeyproperty set it will delete it and write its value toapiTokeninstead. It will then persist the config.This way users should automatically migrate to the new key and in a next major bump we can remove this migration logic. Anyone who wasn't auto-migrated will simply be considered logged out so they can
socket loginto remedy that, no big deal.