Skip to content

Abstract bad input reporter to make it more consistent#384

Merged
jdalton merged 5 commits intomainfrom
input_error
Mar 26, 2025
Merged

Abstract bad input reporter to make it more consistent#384
jdalton merged 5 commits intomainfrom
input_error

Conversation

@pvdz
Copy link
Contributor

@pvdz pvdz commented Mar 25, 2025

This abstracts the input error reporting to be done by one function.

The advantage is that it looks cleaner on the command files side of things with the output being consistent across all commands. Same coloring, markup, indentation, etc.

Later we'll be able to more easily handle the markdown/json cases, too.

@pvdz pvdz requested a review from jdalton March 25, 2025 17:38
Copy link
Contributor

@jdalton jdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails

@pvdz pvdz requested a review from jdalton March 26, 2025 09:47
@jdalton jdalton enabled auto-merge (squash) March 26, 2025 11:25
@jdalton jdalton merged commit 6f45bab into main Mar 26, 2025
8 checks passed
@jdalton jdalton deleted the input_error branch March 26, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants