Allow config override through --config or env.SOCKET_CLI_CONFIG#383
Merged
Allow config override through --config or env.SOCKET_CLI_CONFIG#383
Conversation
jdalton
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to override the local config through either an env var (
SOCKET_CLI_CONFIG) or flag (--config).When an override is used, config changes will not be persisted to disk.
The main goal is to add an easy way for tests to use different configs without having to set up heavy machinery for it. But it's also a common feature seen in other packages so why not.
This will add a hidden flag
--configto almost all commands.Drops
processimports because that's an auto-global in nodejs.All tests are updated to use
--config {}, where supported. Lots of churn in the test files as a result. Would ignore that in the review.This PR also fixes a bunch of the
dry-runtests 🙈 because they were still using--help.