Skip to content

Refactor many commands into consistency#330

Merged
pvdz merged 3 commits intomainfrom
refactor_a_lot
Feb 18, 2025
Merged

Refactor many commands into consistency#330
pvdz merged 3 commits intomainfrom
refactor_a_lot

Conversation

@pvdz
Copy link
Contributor

@pvdz pvdz commented Feb 18, 2025

This refactors a bunch of commands in the same style as #322 and some of the others.

I can cut this up in one PR per command if that's easier to process. Ultimately it should not change semantics, only split CLI command handling from the actual thing being executed. And pull the CLI reporting (meow) straight across all commands, where possible.

  • is action a github action handler? it's unlisted, do we care/keep/use it?
  • how do we safely convert cdxgen to use meow instead of yargs?

@pvdz pvdz requested a review from jdalton February 18, 2025 13:17
Copy link
Contributor

@jdalton jdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the naming nit tweaks looks good to land

(The request changes bit was a UI glitch. Meant to be "approved")

@pvdz pvdz merged commit 96e3769 into main Feb 18, 2025
15 checks passed
@pvdz pvdz deleted the refactor_a_lot branch February 18, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants