-
Notifications
You must be signed in to change notification settings - Fork 40
Remove tap, replace with vitest #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
3f60017
tmp
pvdz 507a33a
POC: migrate to vitest
pvdz fdd5264
Merge branch 'main' into vitest_poc
pvdz 246a0f4
npm run fix
pvdz c814caa
Drop last TAP reference
pvdz 7d932d2
Extend test time allowance for ci
pvdz 383a94d
30?
pvdz cc6b57d
whats going on here
pvdz b18277b
explicitly pipe output
pvdz f992ba4
Merge branch 'main' into vitest_poc
pvdz 280e76a
prevent timeouts when we can see npm simply ran to completion incorre…
pvdz 85c42c2
undo the piping
pvdz 3ec1806
boundaries
pvdz ad4c279
needs error obj but doesnt change anything
pvdz 59b27ca
ok
pvdz b53e033
Does this work?
pvdz 1f33343
Why do we even need them for the test
pvdz 9bb8515
dis one? (tmp)
pvdz 1b03ba8
Merge branch 'main' into vitest_poc
pvdz d615681
test
pvdz ba037de
revert some changes
pvdz b2aaa98
ohhhh
pvdz f2ec472
assert true
pvdz 63180cf
grr
pvdz 10f17c8
yunowin
pvdz 9bf2aa5
Set timeout for test
pvdz 1ebe116
Undo debugging stuff and lets go
pvdz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer need to add this as it's added before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the TAP one is redundant too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gonna merge. if redundant we can drop it in a separate PR. it doesnt seem to block right now