Skip to content

chore(ci): cascade socket-registry pin to 85a2fc0d#1285

Closed
John-David Dalton (jdalton) wants to merge 4 commits intomainfrom
chore/registry-cascade
Closed

chore(ci): cascade socket-registry pin to 85a2fc0d#1285
John-David Dalton (jdalton) wants to merge 4 commits intomainfrom
chore/registry-cascade

Conversation

@jdalton
Copy link
Copy Markdown
Collaborator

@jdalton John-David Dalton (jdalton) commented Apr 27, 2026

Self-landable split from #1279.

Bumps SocketDev/socket-registry workflow pins from ea1986b8 to 85a2fc0d. Picks up:

  • bootstrap-from-registry step in install/action.yml (pre-seeds @socketsecurity/lib before pnpm install)
  • path-guard fleet cascade

Test plan

  • CI passes

Note

Medium Risk
Medium risk because it changes the pinned versions of shared CI/publish automation (setup-and-install and git-signing actions), which can affect build, test, and release behavior even though no product code changes.

Overview
Bumps the pinned SocketDev/socket-registry action revision across ci.yml, provenance.yml, and weekly-update.yml (from ea1986b8… to 85a2fc0d…).

This updates the versions used for dependency setup/installation and the weekly-update git signing/cleanup steps, aligning CI, publishing, and automation with the newer shared workflow implementation.

Reviewed by Cursor Bugbot for commit 9ef28f8. Configure here.

Picks up the latest socket-registry workflow updates (currently the
bootstrap-from-registry step in install/action.yml + the path-guard
fleet rollout cascade).

Self-landable split from #1279.
Picks up the firewall-checker fix in @SocketDev/socket-registry —
any alert from Socket Firewall now blocks the bootstrap (no severity
threshold; the API only returns alerts when a package is flagged
as malware, so any alert means malware).

Cascade chain:
  check-firewall.mts        Layer 1  e4193847
  setup-and-install         Layer 2  b94c9571
  reusable workflows        Layer 3  85a2fc0d  ← propagation SHA
  _local-not-for-reuse-*    Layer 4  25ec2c76  (socket-registry only)
@jdalton
Copy link
Copy Markdown
Collaborator Author

bugbot run

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9ef28f8. Configure here.

@jdalton
Copy link
Copy Markdown
Collaborator Author

Superseded by #1302, which bumps the cascade pin to a current SHA
(51f34ffb) and bundles deps drift in the same PR per project
direction. This branch had gone stale at @0fc1abfd while
@ea1986b8 merged via #1278, and #1302 includes everything between.

John-David Dalton (jdalton) added a commit that referenced this pull request May 5, 2026
Bumps the three workflow files (ci.yml, provenance.yml,
weekly-update.yml) to socket-registry@51f34ffb. That commit
includes:

- 4c4b12cc — pnpm 11.0.6 GA + Rust toolchain pin for Node 26
  Temporal + SRI integrity migration in external-tools.json
- e5f83c31 — wire updating-xport into the umbrella drift flow
- 51f34ffb — release-workflow-guard quote-mask false-positive fix

Closes the chore/registry-cascade branch (PR #1285) which had
gone stale at @0fc1abfd while @ea1986b8 merged via #1278.
John-David Dalton (jdalton) added a commit that referenced this pull request May 5, 2026
Synced from socket-repo-template canonical. The fleet CLAUDE.md
moved to a fleet-canonical / project-specific layout — public-surface
hygiene rules, parallel-session safeguards, code style, and tooling
go in CLAUDE.md; project-specific extensions (build commands, test
targets, repo-particular conventions) go below.

Skills added:
- path-guard — audit and fix path duplication ("1 path, 1 reference")
- programmatic-claude-lockdown — reference for locking down headless
  Claude invocations (claude CLI in workflows, agent-sdk query() in
  code) per the four-flag lockdown pattern
- promise-race-pitfall — reference for the Promise.race
  cross-iteration handler-leak bug

Skills updated:
- security-scan — wires AgentShield + zizmor + Socket CLI dependency
  scanning, A-F graded report

Path-guard infra:
- scripts/check-paths.mts — repo-level path-duplication scanner
- .github/paths-allowlist.yml — known-acceptable duplicates
- .claude/skills/path-guard/reference/* — templates for new repos

Doctrine references:
- docs/references/inclusive-language.md — substitution table
- docs/references/sorting.md — alphanumeric sort rules

Repo-template integration:
- .socket-repo-template.json — repo-particular kind config
- scripts/socket-repo-template-{schema,emit-schema}.mts — schema tooling
- socket-repo-template-schema.json — emitted JSON schema

Splits content out of #1286. Companion split PR #1300 covers hooks +
harness config; deps_misc bucket folds into #1285 SHA cascade per
project direction.
John-David Dalton (jdalton) added a commit that referenced this pull request May 5, 2026
…1301)

* docs(claude+skills): CLAUDE.md restructure + path-guard + new skills

Synced from socket-repo-template canonical. The fleet CLAUDE.md
moved to a fleet-canonical / project-specific layout — public-surface
hygiene rules, parallel-session safeguards, code style, and tooling
go in CLAUDE.md; project-specific extensions (build commands, test
targets, repo-particular conventions) go below.

Skills added:
- path-guard — audit and fix path duplication ("1 path, 1 reference")
- programmatic-claude-lockdown — reference for locking down headless
  Claude invocations (claude CLI in workflows, agent-sdk query() in
  code) per the four-flag lockdown pattern
- promise-race-pitfall — reference for the Promise.race
  cross-iteration handler-leak bug

Skills updated:
- security-scan — wires AgentShield + zizmor + Socket CLI dependency
  scanning, A-F graded report

Path-guard infra:
- scripts/check-paths.mts — repo-level path-duplication scanner
- .github/paths-allowlist.yml — known-acceptable duplicates
- .claude/skills/path-guard/reference/* — templates for new repos

Doctrine references:
- docs/references/inclusive-language.md — substitution table
- docs/references/sorting.md — alphanumeric sort rules

Repo-template integration:
- .socket-repo-template.json — repo-particular kind config
- scripts/socket-repo-template-{schema,emit-schema}.mts — schema tooling
- socket-repo-template-schema.json — emitted JSON schema

Splits content out of #1286. Companion split PR #1300 covers hooks +
harness config; deps_misc bucket folds into #1285 SHA cascade per
project direction.

* fix(check-paths): Rule F requires >=2 distinct files, not just >=2 hits

Cursor Bugbot caught: `checkRuleF` grouped Rule-A findings purely by
string-literal shape and promoted to Rule F whenever count >= 2,
without checking distinct files. Two hand-builds of the same path
shape in the SAME file would be incorrectly flagged as 'cross-file
repetition' — but Rule F's whole point is cross-file duplication.

Fix: build a Set of distinct file paths and gate the promotion on
size >= 2. Also include the file count in the message
(`in N files (M places)`) so the reviewer knows both numbers.
Synced to socket-repo-template canonical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants