Skip to content

fix: default to cwd when --reach is used without explicit target #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtorp merged 2 commits into from
Mar 19, 2026
+25 −8
Merged

fix: default to cwd when --reach is used without explicit target #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
572fbcc
fix: default to cwd when --reach is used without explicit target
mtorp Mar 19, 2026
35a901c
fix: default to cwd when --reach is used without explicit target
mtorp Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## [1.1.74](https://github.com/SocketDev/socket-cli/releases/tag/v1.1.74) - 2026-03-19

### Fixed
- Fixed `socket scan create --reach` failing with input validation errors when no explicit target is passed. In non-TTY environments (e.g. Jenkins CI), the interactive prompt to confirm the current directory would silently fail, causing all reach validations to error. Now defaults to `.` (cwd) when `--reach` is used without a target.

### Changed
- Updated the Coana CLI to v `14.12.200`.

## [1.1.73](https://github.com/SocketDev/socket-cli/releases/tag/v1.1.73) - 2026-03-13

### Changed
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "socket",
"version": "1.1.73",
"version": "1.1.74",
"description": "CLI for Socket.dev",
"homepage": "https://github.com/SocketDev/socket-cli",
"license": "MIT AND OFL-1.1",
Expand Down Expand Up @@ -97,7 +97,7 @@
"@babel/preset-typescript": "7.27.1",
"@babel/runtime": "7.28.4",
"@biomejs/biome": "2.2.4",
"@coana-tech/cli": "14.12.197",
"@coana-tech/cli": "14.12.200",
"@cyclonedx/cdxgen": "12.1.2",
"@dotenvx/dotenvx": "1.49.0",
"@eslint/compat": "1.3.2",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion src/commands/scan/cmd-scan-create.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,13 +381,22 @@ async function run(
let updatedInput = false

// Accept zero or more paths. Default to cwd() if none given.
let targets = cli.input || [cwd]
let targets = cli.input.length ? cli.input : []

if (!targets.length && !dryRun && interactive) {
targets = await suggestTarget()
updatedInput = true
}

// Fallback: if targets is still empty after the interactive prompt (e.g. the
// select() prompt silently fails in non-TTY environments like Jenkins CI
// because wrapPrompt swallows non-TypeError errors and returns undefined),
// default to '.' so that downstream validations don't fail with confusing
// "At least one TARGET (missing)" errors.
if (!targets.length && !dryRun) {
targets = ['.']
}

// We're going to need an api token to suggest data because those suggestions
// must come from data we already know. Don't error on missing api token yet.
// If the api-token is not set, ignore it for the sake of suggestions.
Expand Down
Loading