Conversation
ahmadnassri
approved these changes
Mar 20, 2026
Signed-off-by: lelia <lelia@socket.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 DO NOT MERGE UNTIL #46 IS MERGED + TESTED
PR #46 introduces the publish pipeline and the pre-built GHCR image architecture. The
action.ymlcan only reference a pre-built image that already exists in GHCR, but the pipeline that publishes those images is being introduced in the same PR. Since we can't publish before the pipeline exists, we also can't reference an image before it's published.The two-PR approach breaks the cycle: PR #46 ships the pipeline with
action.ymlstill building fromDockerfile(no regression for current users), then this PR bumps tov2.0.0and switchesaction.ymlto the pre-built image only after the infrastructure is proven and the image is live in GHCR.UPDATE: PR #46 merged, testing/fixes applied, publish-docker now passing 🎉