Skip to content

Add Lightspeed Reatail provider#1373

Closed
dansleboby wants to merge 3 commits intoSocialiteProviders:masterfrom
dansleboby:master
Closed

Add Lightspeed Reatail provider#1373
dansleboby wants to merge 3 commits intoSocialiteProviders:masterfrom
dansleboby:master

Conversation

@dansleboby
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/LightspeedRetail/Provider.php Outdated
{
const IDENTIFIER = 'LIGHTSPEEDRETAIL';

protected $scopes = [''];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just leave this as an empty array please?

Comment thread src/LightspeedRetail/Provider.php Outdated
));

// Store domain prefix with the user
$user->domainPrefix = $this->domainPrefix;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be set on the raw data right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, create a custom user object with this prop.

protected function getTokenUrl()
{
// We must get the domain_prefix from the callback for the initial token request
$domainPrefix = request()->input('domain_prefix', $this->domainPrefix);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to get this from the url? example.com/# results in
curl 'https://example.com/#.retail.lightspeed.app/api/1.0/token'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you address this please

protected function getTokenUrl()
{
// We must get the domain_prefix from the callback for the initial token request
$domainPrefix = request()->input('domain_prefix', $this->domainPrefix);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you address this please

@atymic atymic closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants