Skip to content

Comments

Improve P2E transfer#1714

Merged
yrong merged 2 commits intomainfrom
ron/improve-p2e
Feb 22, 2026
Merged

Improve P2E transfer#1714
yrong merged 2 commits intomainfrom
ron/improve-p2e

Conversation

@yrong
Copy link
Contributor

@yrong yrong commented Feb 15, 2026

Context

For transfers from a non-system parachain to Ethereum, since we perform a full dry-run check at each node/hop, the previous fallback XCM — which sent assets back to the source chain from AH when execution failed on AH — is no longer necessary.

This PR removes that fallback, slightly reduces fees, and has been tested and verified with a V2 transfer from Bifrost, which worked as expected.

https://app.snowbridge.network/activity#0x7a788c60bd72580111a5b4cbab1bed244f8f6e134d78a97310afadb7eae39d01

@yrong
Copy link
Contributor Author

yrong commented Feb 15, 2026

Tested that the V2 transfer does not work on Acala, as the runtime does not permit PolkadotXcm.execute, as shown here:
https://github.com/AcalaNetwork/Acala/blob/eb004a3cdb18cae68875e080e1b731c996dd3dc1/runtime/acala/src/lib.rs#L238

@yrong yrong marked this pull request as ready for review February 16, 2026 06:48
@claravanstaden
Copy link
Contributor

Does it hurt to keep "return to sender" in? I think its a nice fallback, but @alistair-singh would have the final say on this :)

@yrong
Copy link
Contributor Author

yrong commented Feb 16, 2026

Does it hurt to keep "return to sender" in? I think its a nice fallback

It will help users save some costs. By the way, I left the V1 path untouched. For V2, since we already have an optional claimerLocation — typically the original sender —it is internally handled as SetHints(Claimer), which follows more of an XCM V5–style approach.

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claravanstaden Since we are only doing this for v2 paths only where dryRun is guaranteed i think its fine to do this. The return to sender code costs a lot by the time we apply padding, and sometimes i think we apply padding on padding so its way too expensive. Its also error prone and not 100% guaranteed to return to sender, it can sometimes fail, such as not having enough fees. So I am for this both simplifying code and lowering cost.

@yrong yrong merged commit 8d68b14 into main Feb 22, 2026
1 check passed
@yrong yrong deleted the ron/improve-p2e branch February 22, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants