Feature/bugs and extra modules#11
Conversation
Market wasn't searching becuase of the Christmas UI. AutoPY was taking 1min to load because I have millions of files in Local App Data
| # Log screen resolution | ||
| logger.info(f"Detected screen resolution: width={self.width}, height={self.height}, primary={main}") | ||
|
|
||
| if main: # Only consider the primary monitor |
There was a problem hiding this comment.
I have two different sized monitors and this error kept kicking off for me even though my main is set to 1920x1080.
moving the main check up here fixed it for me.
| logger.info("Starting focused search for Raid.exe...") | ||
| appdata_local = os.path.join(os.environ['LOCALAPPDATA']) | ||
| raid_feature = "Raid.exe" | ||
| for root, dirs, files in os.walk(appdata_local): |
There was a problem hiding this comment.
Making this change made my start up time go from 1min to 2s
| try: | ||
| # Attempt to locate the image | ||
| if pyautogui.locateOnScreen(exit_add_image, confidence=0.7) is not None: | ||
| if pyautogui.locateOnScreen(exit_add_image, confidence=0.7) is not None or pyautogui.locateOnScreen(home_battle_button, confidence=0.7): |
There was a problem hiding this comment.
If exit image wasn't on the screen it would loop here without the tk ui popping up. Now I also check for being on the bastion without a pop up by looking for the battle button
There was a problem hiding this comment.
I've realised this one might not be the intention you had. Is it supposed to attempt to escape so the exit button comes up and then close to make sure we are in the bastion without popups?
|
@ToonDawg I appreciate the work , and am looking to refactor a lot of this very soon. I will review all of this and love your additions. Thanks for the help! |
|
Hey man! No worries. I haven't looked at this or tried it in a while. It may be risky PR now. Specially with the shop updates and stuff. I'm happy to close it |
|
No I pulled this PR and testing. I was wanting to do these things but got busy. Im sure we can get this working and add it to the functionality |
2 participants
Yo! A bit of a bigger PR here that fixed 2 issues I was having. I wasn't able to comment on the PR lines to explain my thoughts, so Ill just do it here.
Cheers mate!