Update ABLP Loader in preparation for graph store#478
Update ABLP Loader in preparation for graph store#478kmontemayor2-sc wants to merge 4 commits intomainfrom
Conversation
|
/unit_test_py |
|
/integration_test |
|
/e2e_test |
GiGL Automation@ 24:33:55UTC : 🔄 @ 01:56:33UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 24:33:57UTC : 🔄 @ 01:52:54UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 24:34:02UTC : 🔄 @ 02:06:03UTC : ✅ Workflow completed successfully. |
|
/unit_test_py |
|
/integration_test |
GiGL Automation@ 17:43:26UTC : 🔄 @ 19:02:17UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 17:43:26UTC : 🔄 @ 18:56:46UTC : ✅ Workflow completed successfully. |
|
/e2e_test |
GiGL Automation@ 17:45:54UTC : 🔄 @ 19:01:14UTC : ✅ Workflow completed successfully. |
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Left a few comments.
| num_cpu_threads=num_cpu_threads, | ||
| ) | ||
|
|
||
| self._is_input_heterogeneous = dataset_metadata.is_labeled_heterogeneous |
There was a problem hiding this comment.
Aren't these two different things? One is asking if the input is heterogeneous, the other is checking if we are in a "labeled heterogeneous" setting.
| self._is_input_heterogeneous: bool = False | ||
|
|
||
| is_labeled_heterogeneous: bool = False |
There was a problem hiding this comment.
Ditto here as well on equating these two
| edge_dir=dataset.edge_dir, | ||
| seed=None, # it's actually optional - None means random. | ||
| return ( | ||
| [sampler_input], |
There was a problem hiding this comment.
Sorry I forgot why does this need to be a list again versus just the ABLPSamplerInput?
3 participants
Scope of work done
Breaking out the changes to support colocated in graph store mode to their own PR (this one) so it's easier to review. In hindsight, #432 was probably too complicated and the ABLP changes will be even more so.
See #475 for the MVP here.
This PR should be a no-op (other than fixing some typos in logs).
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO