Draft
Conversation
mkolodner-sc
approved these changes
Feb 6, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Generally LGTM, as we are primarily just migrating code from GLT IIUC.
| from gigl.distributed.dist_context import DistributedContext | ||
| from gigl.distributed.dist_dataset import DistDataset | ||
| from gigl.distributed.dist_sampling_producer import DistSamplingProducer | ||
| from gigl.distributed.dist_sampling_producer import DistAblpSamplingProducer |
Collaborator
There was a problem hiding this comment.
nit: DistAblpSamplingProducer -> DistABLPSamplingProducer I believe we've taken this approach with existing ABLP classnames [1].
Ditto elsewhere
gigl/distributed/dist_server.py
Outdated
|
|
||
|
|
||
| # TODO(kmonte): Migrate graph_store/storage_utils to this class. | ||
| class DistServer(object): |
Collaborator
There was a problem hiding this comment.
This might come off as a generic DistServer that can be used, when in reality its only practical for the ABLP use case right? We should probably name it as such
Collaborator
Author
|
/integration_test |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 23:47:23UTC : 🔄 @ 24:55:30UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 23:47:29UTC : 🔄 @ 01:14:59UTC : ✅ Workflow completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
We need to do this as for GraphStore mode we need to initiate the sampling producers on the servers, which has been done inside the GLT
dist_loader1, but since we have our own sampling producer with ABLP logic 2, we need to call that producer.Ultimately the
DistServeris responsible for instantiating the producer 3 so we need to have our own server.Also rename our
DistSamplingProducer->DistAblpSamplingProducerto clarify (I was getting confused as the two names are very similar otherwise).I'll have a follow-up to migrate the
storage_utilsstuff to this class :)I do have an MVP for the ablp loader with graph store - see #475
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO