[Custom Storage 2/3] Implement custom storage main#462

Merged

kmontemayor2-sc merged 18 commits intokmonte/custom-storage-main-defsfrom

kmonte/custom-storage-main-impl

Feb 3, 2026

Collaborator

kmontemayor2-sc commented Jan 22, 2026 •

edited

Loading

Scope of work done

Implement logic for custom storage main

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

kmonte added 2 commits

January 22, 2026 18:40


          Setup to launch custom storage

a25e95a


          fixes

7c61849

This was referenced Jan 22, 2026

[Custom Storage 2/3] Implement custom storage main #460

Closed

[Custom Storage 3/3] Add validation for custom storage main #463

Merged

Collaborator Author

kmontemayor2-sc commented Jan 22, 2026

/e2e_test

Collaborator Author

kmontemayor2-sc commented Jan 22, 2026

/integration_test

Contributor

github-actions bot commented Jan 22, 2026 •

edited

Loading

GiGL Automation

@ 21:28:16UTC : 🔄 E2E Test started.

@ 22:50:50UTC : ✅ Workflow completed successfully.

Contributor

github-actions bot commented Jan 22, 2026 •

edited

Loading

GiGL Automation

@ 21:28:41UTC : 🔄 Integration Test started.

@ 22:33:15UTC : ✅ Workflow completed successfully.

kmontemayor2-sc mentioned this pull request

[Custom Storage 1/3] Add defs for custom storage main #459

Merged

kmonte added 2 commits

January 23, 2026 00:25


          Merge branch 'kmonte/custom-storage-main-defs' into kmonte/custom-sto…

0e5b5f7

…rage-main-impl


          evolve

83dde42

mkolodner-sc reviewed

View reviewed changes

Collaborator

mkolodner-sc left a comment

Thanks Kyle! Left a round of comments. Generally, it could be useful to add more detail to the PR description here for the scope of the changes in this PR.

examples/link_prediction/graph_store/storage_main.py Outdated Show resolved Hide resolved

python/tests/test_assets/distributed/utils.py Show resolved Hide resolved

python/gigl/distributed/graph_store/storage_main.py Outdated Show resolved Hide resolved

gigl/distributed/graph_store/storage_main.py Show resolved Hide resolved

examples/link_prediction/graph_store/storage_main.py Show resolved Hide resolved

examples/link_prediction/graph_store/storage_main.py Show resolved Hide resolved

examples/link_prediction/graph_store/storage_main.py Show resolved Hide resolved

examples/link_prediction/graph_store/storage_main.py Show resolved Hide resolved

examples/link_prediction/graph_store/configs/e2e_hom_cora_sup_gs_task_config.yaml Outdated Show resolved Hide resolved

examples/link_prediction/graph_store/storage_main.py Show resolved Hide resolved

kmonte added 3 commits

January 26, 2026 19:31


          Merge branch 'main' into kmonte/custom-storage-main-impl

d7bd17f


          pr comments

553db5e


          Merge branch 'kmonte/custom-storage-main-defs' into kmonte/custom-sto…

571e927

…rage-main-impl

mkolodner-sc reviewed

View reviewed changes

examples/link_prediction/graph_store/storage_main.py Show resolved Hide resolved

examples/link_prediction/graph_store/storage_main.py Show resolved Hide resolved

gigl/distributed/graph_store/storage_main.py Show resolved Hide resolved


          comments

41f0b82

svij-sc reviewed

View reviewed changes

examples/link_prediction/graph_store/storage_main.py Outdated Show resolved Hide resolved

gigl/src/common/vertex_ai_launcher.py Outdated Show resolved Hide resolved

kmonte added 5 commits

January 28, 2026 00:54


          update

70119f2


          Merge branch 'kmonte/custom-storage-main-defs' into kmonte/custom-sto…

6c0c365

…rage-main-impl


          address comments

907bafa


          todo

8a1357f


          stop using build_dataset_from_task_config_uri

b6ac432

Collaborator Author

kmontemayor2-sc commented Jan 29, 2026

/unit_test_py

Collaborator Author

kmontemayor2-sc commented Jan 29, 2026

/integration_test

Contributor

github-actions bot commented Jan 29, 2026 •

edited

Loading

GiGL Automation

@ 21:23:33UTC : 🔄 Python Unit Test started.

@ 21:29:25UTC : ❌ Workflow failed.
Please check the logs for more details.

Collaborator Author

kmontemayor2-sc commented Jan 29, 2026

/e2e_test

Contributor

github-actions bot commented Jan 29, 2026 •

edited

Loading

GiGL Automation

@ 21:23:46UTC : 🔄 E2E Test started.

@ 22:41:39UTC : ❌ Workflow failed.
Please check the logs for more details.

Contributor

github-actions bot commented Jan 29, 2026 •

edited

Loading

GiGL Automation

@ 21:23:47UTC : 🔄 Integration Test started.

@ 22:37:41UTC : ✅ Workflow completed successfully.


          update

ef710a9


          fixes

f1e1b60

Collaborator Author

kmontemayor2-sc commented Jan 29, 2026

/unit_test_py

Collaborator Author

kmontemayor2-sc commented Jan 29, 2026

/e2e_test

Contributor

github-actions bot commented Jan 29, 2026 •

edited

Loading

GiGL Automation

@ 23:04:36UTC : 🔄 Python Unit Test started.

@ 24:16:02UTC : ✅ Workflow completed successfully.

Contributor

github-actions bot commented Jan 29, 2026 •

edited

Loading

GiGL Automation

@ 23:04:40UTC : 🔄 E2E Test started.

@ 24:28:02UTC : ❌ Workflow failed.
Please check the logs for more details.

fix

9b6ab57

Collaborator Author

kmontemayor2-sc commented Jan 30, 2026

/e2e_test

Collaborator Author

kmontemayor2-sc commented Jan 30, 2026

/integration_test

Collaborator Author

kmontemayor2-sc commented Jan 30, 2026

/unit_test_py

Contributor

github-actions bot commented Jan 30, 2026 •

edited

Loading

GiGL Automation

@ 16:53:21UTC : 🔄 E2E Test started.

@ 18:19:58UTC : ❌ Workflow failed.
Please check the logs for more details.

Contributor

github-actions bot commented Jan 30, 2026 •

edited

Loading

GiGL Automation

@ 16:53:28UTC : 🔄 Python Unit Test started.

@ 18:09:35UTC : ✅ Workflow completed successfully.

Contributor

github-actions bot commented Jan 30, 2026 •

edited

Loading

GiGL Automation

@ 16:53:30UTC : 🔄 Integration Test started.

@ 18:02:28UTC : ✅ Workflow completed successfully.


          update

fe47460

Collaborator Author

kmontemayor2-sc commented Jan 30, 2026

/e2e_test

Contributor

github-actions bot commented Jan 30, 2026 •

edited

Loading

GiGL Automation

@ 18:34:44UTC : 🔄 E2E Test started.

@ 19:55:34UTC : ✅ Workflow completed successfully.

mkolodner-sc approved these changes

View reviewed changes

Collaborator

mkolodner-sc left a comment

Thanks Kyle! One last comment, but stamping to unblock provided it is addressed

gigl/distributed/graph_store/storage_main.py Show resolved Hide resolved

svij-sc approved these changes

View reviewed changes

Collaborator

svij-sc left a comment

No diffs rn, I just don't want to be relying on the example code (more) in our tests.

Its a strat, unsure if I am a fan - we can see how it goes I guess.
I suspect this might go out of sync pretty quick - would pref tested code be self documenting.


          [Custom Storage 3/3] Add validation for custom storage main (#463)

29c55cc

Co-authored-by: kmontemayor <kyle.e.montemayor@gmail.com>

Collaborator Author

kmontemayor2-sc commented Feb 3, 2026

Its a strat, unsure if I am a fan - we can see how it goes I guess.

I agree actually, I think we can consolidate once we have a trainer example out.

kmontemayor2-sc marked this pull request as ready for review

February 3, 2026 05:05

kmontemayor2-sc requested review from nshah-sc, xgao4-sc, yliu2-sc and zfan3-sc as code owners

February 3, 2026 05:05

kmontemayor2-sc merged commit 46c089b into kmonte/custom-storage-main-defs

6 checks passed

kmontemayor2-sc deleted the kmonte/custom-storage-main-impl branch

February 3, 2026 05:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mkolodner-sc mkolodner-sc approved these changes

svij-sc svij-sc approved these changes

nshah-sc Awaiting requested review from nshah-sc

yliu2-sc Awaiting requested review from yliu2-sc

xgao4-sc Awaiting requested review from xgao4-sc

zfan3-sc Awaiting requested review from zfan3-sc

Labels

None yet