[Update Deps] Fix Release#418
Conversation
| 1. Freeze (set explicit versions e.g. `my-lib==1.2.3`) versions of doc deps as version updates changes how the doc pages | ||
| are rendered, files are formatted, etc. | ||
| 2. Freeze versions for deps that don't do a great job of maintaining in their wheels what libs / libraries they are | ||
| compatible with - this is a problem with packages like tensorflow. |
There was a problem hiding this comment.
formatting - realize I forgot to do this in prior PR and merge to main will fail otherwise.
| ref: ${{ needs.bump_version.outputs.release_branch_name }} | ||
|
|
||
| - name: Setup Machine for release | ||
| uses: snapchat/gigl/.github/actions/setup-python-tools@main |
There was a problem hiding this comment.
are we planning on reverting these before submitting?
There was a problem hiding this comment.
No,
Post Merge:
Things that will need to be done after PR is merged in
- Github action workflows comment - Cannot test till merged.
- Post PR merge we will need to update back ./.github/actions/setup-python-tools --> snapchat/gigl/.github/actions/setup-python-tools@main
- Formal release of gigl v0.1.0
There was a problem hiding this comment.
Once the PR is merged in these changes aren't needed anymore right?
There was a problem hiding this comment.
correct, plan is to follow up reverting:
Post PR merge we will need to update back ./.github/actions/setup-python-tools --> snapchat/gigl/.github/actions/setup-python-tools@main
| make push_dev_workbench_docker_image | ||
| service_account: ${{ secrets.gcp_service_account_email }} | ||
| project: ${{ vars.GCP_PROJECT_ID }} | ||
| # TODO: (svij) Let's deprecate this as no one uses it beyond it being used for the TUT. |
There was a problem hiding this comment.
Why not just delete?
There was a problem hiding this comment.
I can, if folks are okay with it.
There was a problem hiding this comment.
actually let me do it as a follow up as to completely deprecate this is a wider change.
Commenting here prevents failures but removing all references is a 5+ file change reserved for a seperate PR.
| conda create -y --override-channels --channel conda-forge --name gigl python=3.9 | ||
| conda activate gigl | ||
| ``` | ||
| 1. Create a python virtual environment w/ `python==3.11.*` |
There was a problem hiding this comment.
This doesn't really explain much, if we want people to use UV, should we just say what UV command to run?
Aren't "virtual envs" abstracted away from users now?
There was a problem hiding this comment.
This is public documentation. We are not constrained to people using conda anymore.
They should be able to use whatever they want to generate their python virtual env i.e. virtualenv, conda, uv, etc.
For dev purposes we can maintain seperate documentation.
There was a problem hiding this comment.
I'd say it's best to provide some recommendation that works for us, e.x. uv it'll make getting started easier
There was a problem hiding this comment.
Sure, I can do this as a follow up as the best way is a little more involved.
Specifically, I think providing a template pyproject.toml for uv will be more helpful.
| pip install "gigl[torch25-cuda-121,transform]==0.0.9" \ | ||
| --index-url=https://us-central1-python.pkg.dev/external-snap-ci-github-gigl/gigl/simple/ \ | ||
| --extra-index-url=https://pypi.org/simple | ||
| pip install "gigl[pyg27-torch28-cu128, transform]==0.1.0" \ |
There was a problem hiding this comment.
pip uv now right? ditto later
There was a problem hiding this comment.
Any reason there aren't new releases in this PR as well?
There was a problem hiding this comment.
Will be done after so we have a clean release of what is in main.
#414 (comment)
Post Merge:
Things that will need to be done after PR is merged in
- Github action workflows comment - Cannot test till merged.
- Post PR merge we will need to update back ./.github/actions/setup-python-tools --> snapchat/gigl/.github/actions/setup-python-tools@main
- Formal release of gigl v0.1.0
Test releases were done here:
#418 (comment)
Testing Plan:
Ran nightly release + api test here: https://github.com/Snapchat/GiGL/actions/runs/20198180696/job/57985597587
Released an actual wheel and subsequently installed it locally to validate it works here: https://github.com/Snapchat/GiGL/actions/runs/20198990587/job/57987110578
| make push_dev_workbench_docker_image | ||
| service_account: ${{ secrets.gcp_service_account_email }} | ||
| project: ${{ vars.GCP_PROJECT_ID }} | ||
| # TODO: (svij) Let's deprecate this as no one uses it beyond it being used for the TUT. |
There was a problem hiding this comment.
If we choose not to deprecate this - it will induce extra work in fixing this - which I am unsure if valuable.
| - bump_version | ||
| - release_gigl_kfp_pipeline | ||
| - release_dev_workbench_image | ||
| # - release_dev_workbench_image |
There was a problem hiding this comment.
We can delete here too
There was a problem hiding this comment.
actually did it as a separate change since its a bit big to delete everything.
svij-sc
requested review from
mkolodner-sc,
nshah-sc,
xgao4-sc and
zfan3-sc
as code owners
3 participants
Following, #414
Release process needs to be fixed.
The process is now fixed (see test plan below), and documentation has also been updated.
We should do an official release of 0.1.0, after all changes are merged in.
Testing Plan: