Rename symbols for standard library compatibility#9
Open
diddyholz wants to merge 2 commits into
Open
Conversation
Collaborator
|
I think it should be better to find other ways. As considered :
It also seems to be possible to do "both", could be interesting to have an updated PR on that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the SDK is not compatible with a C standard library due to it using some symbols such as "open", "write", "memset". This hinders development and therefore I suggest to rename all conflicting functions, structs and enums to use some form of Prefix to distinguish them from the standard library.
In my branch I added the header name as the prefix, as it is already done in LCD.h or MCS.h. I am open to other naming suggestions as well.
I also added a link to my port of newlib in the "development" documentation.