Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new title/subtitle library (smithed.title) that follows the same architectural pattern and specifications as the existing actionbar library. The library provides priority-based title message management to prevent conflicts between different data packs trying to display titles simultaneously.
Key changes:
- Creates a complete title library with priority-based message queueing and display management
- Implements freeze duration controls to prevent message spam
- Integrates the new title library with the existing actionbar library initialization
Reviewed Changes
Copilot reviewed 9 out of 36 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| smithed_libraries/packs/title/data/smithed.title/function/impl/technical/tick.mcfunction | Main tick loop for managing title freeze timers and cleanup |
| smithed_libraries/packs/title/data/smithed.title/function/impl/technical/load.mcfunction | Initialization of scoreboards and constants for the title system |
| smithed_libraries/packs/title/data/smithed.title/function/impl/reset.mcfunction | Player title state reset functionality |
| smithed_libraries/packs/title/data/smithed.title/function/impl/message.mcfunction | Core message processing and priority handling logic |
| smithed_libraries/packs/title/data/smithed.title/function/impl/display.mcfunction | Title display execution with bounds checking |
| smithed_libraries/packs/title/beet.yaml | Build configuration for the title library package |
| smithed_libraries/packs/title/README.md | Documentation file with incorrect content referencing actionbar |
| smithed_libraries/packs/actionbar/data/smithed.actionbar/function/impl/technical/load.mcfunction | Integration of title library initialization into actionbar load |
| smithed_libraries/packs/actionbar/beet.yaml | Updated build configuration |
Comments suppressed due to low confidence (1)
|
Download the artifacts for this pull request: |
Collaborator
|
omg how have i missed this |
Stoupy51
approved these changes
Dec 26, 2025
Contributor
Stoupy51
left a comment
Stoupy51
left a comment
There was a problem hiding this comment.
Now needs to update the docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a new lib
smithed.titleusing the same specs as actionbar lib.This PR is paired with docs PR