Skip to content

Conversation

@rossiam
Copy link
Collaborator

@rossiam rossiam commented Dec 22, 2025

Put back in code that only runs some jobs if the changesets step of the npm-release job actually publishes, but changed slightly how it determines whether a publish happens or not. (Previously it had code that checked specifically if the packages/cli package was published but this is no longer a mono-repo.

For those not familiar with this somewhat unusual setup, the changesets step of the npm-release job does either one of two things:

  1. If this is a "normal commit" (which should include new change sets in the .changeset directory), it should create (or update if one already exists) a pull request for doing a release.
  2. If this is a merge of a pull request created by option 1, a release is actually made.

I think there might be something still broken though because I would have expected that PR to be generated even though other later steps are failing. We might have to force it with a new fake changeset or something.

@rossiam rossiam requested a review from a team December 22, 2025 18:16
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: 3db7060

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rossiam rossiam merged commit 5c72948 into SmartThingsCommunity:main Dec 22, 2025
4 checks passed
@rossiam rossiam deleted the yet-more-release-fixes branch December 22, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants