Skip to content

Matter Thermostat: Support fanSpeedPercent #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickolas-deboom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Matter Thermostat: Support fanSpeedPercent #2670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions drivers/SmartThings/matter-thermostat/profiles/thermostat-modular.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ components:
- id: fanMode
version: 1
optional: true
- id: fanSpeedPercent
version: 1
optional: true
- id: fanOscillationMode
version: 1
optional: true
Expand Down
2 changes: 2 additions & 0 deletions drivers/SmartThings/matter-thermostat/src/test/test_matter_thermo_multiple_device_types.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ local expected_metadata = {
"main",
{
"relativeHumidityMeasurement",
"fanSpeedPercent",
"fanMode",
"fanOscillationMode",
"thermostatHeatingSetpoint",
Expand All @@ -220,6 +221,7 @@ local new_cluster_subscribe_list = {
clusters.RelativeHumidityMeasurement.attributes.MeasuredValue,
clusters.FanControl.attributes.FanMode,
clusters.FanControl.attributes.FanModeSequence,
clusters.FanControl.attributes.PercentCurrent,
clusters.FanControl.attributes.RockSupport, -- These two attributes will be subscribed to following the profile
clusters.FanControl.attributes.RockSetting, -- change since the fanOscillationMode capability will be enabled.
}
Expand Down
9 changes: 8 additions & 1 deletion drivers/SmartThings/matter-thermostat/src/thermostat_utils/device_configuration.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,14 @@ function DeviceConfiguration.match_modular_profile_thermostat(device)
local wind_eps = device:get_endpoints(clusters.FanControl.ID, {feature_bitmap = clusters.FanControl.types.FanControlFeature.WIND})

if #fan_eps > 0 then
table.insert(main_component_capabilities, capabilities.fanMode.ID)
if #device:get_endpoints(clusters.FanControl.ID, {feature_bitmap = clusters.FanControl.types.Feature.MULTI_SPEED}) > 0 then
table.insert(main_component_capabilities, capabilities.fanSpeedPercent.ID)
if #device:get_endpoints(clusters.FanControl.ID, {feature_bitmap = clusters.FanControl.types.Feature.AUTO}) > 0 then
table.insert(main_component_capabilities, capabilities.fanMode.ID)
end
else
table.insert(main_component_capabilities, capabilities.fanMode.ID)
end
end
if #rock_eps > 0 then
table.insert(main_component_capabilities, capabilities.fanOscillationMode.ID)
Expand Down
Loading