CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials capability #2416

pegor-karoglanian · 2025-09-19T19:25:12Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

CLAassistant · 2025-09-19T19:25:19Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ greens
❌ pegor-karoglanian
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2025-09-19T19:25:37Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-09-19T19:26:30Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/8zM743or6v2p

github-actions · 2025-09-19T19:28:56Z

Test Results

71 files 483 suites 0s ⏱️
2 499 tests 2 467 ✅ 0 💤 32 ❌
4 279 runs 4 247 ✅ 0 💤 32 ❌

For more details on these failures, see this check.

Results for commit 0d7fe54.

♻️ This comment has been updated with latest results.

github-actions · 2025-09-19T19:28:58Z

zigbee-lock_coverage.xml

File	Coverage
All files	`73%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua	`78%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/yale-bad-battery-reporter/init.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/samsungsds/init.lua	`65%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/lock-without-codes/init.lua	`76%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/yale/init.lua	`81%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua	`42%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/init.lua	`23%`	❌

zwave-lock_coverage.xml

File	Coverage
All files	`51%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua	`78%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/yale-bad-battery-reporter/init.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/samsungsds/init.lua	`65%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/lock-without-codes/init.lua	`76%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/yale/init.lua	`81%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua	`42%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/init.lua	`23%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/samsung-lock/init.lua	`42%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/init.lua	`79%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/can_handle.lua	`85%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/zwave-alarm-v1-lock/init.lua	`20%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/schlage-lock/init.lua	`37%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/init.lua	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/keywe-lock/init.lua	`52%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-new-capabilities/can_handle.lua	`71%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0d7fe54

drivers/SmartThings/zigbee-lock/src/init.lua

drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_slga_migration.lua

drivers/SmartThings/zigbee-lock/src/init.lua

drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_slga_migration.lua

drivers/SmartThings/zigbee-lock/src/init.lua

drivers/SmartThings/zwave-lock/src/init.lua

drivers/SmartThings/zigbee-lock/src/init.lua

pegor-karoglanian · 2025-12-10T23:17:28Z

12/10 update: Converted this PR to draft since a lot more is now going in. The latest commit adds all the commands for lockUsers and lockCredentials along with unit tests covering most of them. There are still more test cases I need to add and to tweak some of the functionality.

drivers/SmartThings/zigbee-lock/src/using-old-capabilities/init.lua

greens · 2025-12-11T00:50:54Z

drivers/SmartThings/zigbee-lock/src/using-new-capabilities/samsungsds/init.lua

@@ -0,0 +1,121 @@
+-- Copyright 2022 SmartThings


nit, but this date should be updated

drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua

greens · 2025-12-11T01:00:01Z

drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua

+local LockUsers = capabilities.lockUsers
+local INITIAL_INDEX = 1
+
+local new_lock_utils =  {


it's unlikely you'll need all of these strings, and, in general, they should be available from inside the capabilities themselves.

drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua

drivers/SmartThings/zigbee-lock/src/using-old-capabilities/samsungsds/init.lua

pegor-karoglanian · 2025-12-23T00:57:12Z

drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_migration.lua

        })
-      }
+      },
+      useOldCapabilityForTesting = true


Not sure if this is an appropriate way to go about this. Open to suggestions.

pegor-karoglanian requested a review from greens September 19, 2025 19:25

greens reviewed Sep 19, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/init.lua Outdated Show resolved Hide resolved

greens reviewed Sep 19, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/init.lua Outdated Show resolved Hide resolved

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch 2 times, most recently from b8168d4 to 36fa094 Compare September 29, 2025 20:25

pegor-karoglanian marked this pull request as ready for review September 29, 2025 20:26

pegor-karoglanian requested review from tpmanley and wkhenon September 29, 2025 20:46

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from 36fa094 to b303430 Compare September 29, 2025 20:47

greens reviewed Sep 29, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_slga_migration.lua Outdated Show resolved Hide resolved

greens reviewed Sep 29, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/init.lua Outdated Show resolved Hide resolved

greens reviewed Sep 29, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/init.lua Outdated Show resolved Hide resolved

greens reviewed Sep 30, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_slga_migration.lua Outdated Show resolved Hide resolved

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch 3 times, most recently from ecdc2be to c248678 Compare September 30, 2025 22:29

tpmanley reviewed Sep 30, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/init.lua Outdated Show resolved Hide resolved

greens reviewed Sep 30, 2025

View reviewed changes

drivers/SmartThings/zwave-lock/src/init.lua Outdated Show resolved Hide resolved

greens reviewed Sep 30, 2025

View reviewed changes

drivers/SmartThings/zwave-lock/src/init.lua Outdated Show resolved Hide resolved

wkhenon reviewed Oct 1, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/init.lua Outdated Show resolved Hide resolved

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from be53bc5 to 1230bdd Compare December 2, 2025 19:16

tpmanley reviewed Dec 2, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/init.lua Outdated Show resolved Hide resolved

pegor-karoglanian marked this pull request as draft December 10, 2025 23:16

greens reviewed Dec 11, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/using-old-capabilities/init.lua Show resolved Hide resolved

greens reviewed Dec 11, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua Outdated Show resolved Hide resolved

greens reviewed Dec 11, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua Outdated Show resolved Hide resolved

greens reviewed Dec 11, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua Outdated Show resolved Hide resolved

greens reviewed Dec 11, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua Outdated Show resolved Hide resolved

pegor-karoglanian commented Dec 11, 2025

View reviewed changes

drivers/SmartThings/zigbee-lock/src/using-old-capabilities/samsungsds/init.lua Outdated Show resolved Hide resolved

CHAD-16364: SLGA Zigbee: Add lockUsers and lockCredentials capabilities

9c7d6f9

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from 62e48ca to 9c7d6f9 Compare December 22, 2025 23:13

pegor-karoglanian changed the title ~~CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials to profiles and also implement lockCodes:migrate functionality.~~ CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials capability Dec 22, 2025

pegor-karoglanian added 2 commits December 22, 2025 15:27

Add reload command to samsung subdriver

16cd903

Add a way to test the old capabilities.

906e247

pegor-karoglanian commented Dec 23, 2025

View reviewed changes

greens and others added 4 commits December 23, 2025 10:28

SLGA: Z-Wave lock update

8953378

fix issue with nil values in tables

6f1564b

Zwave - Functioning base driver

d924ea5

Fix zwave new capabilites unit tests

ada5f59

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from bff6478 to ada5f59 Compare December 24, 2025 02:43

pegor-karoglanian added 2 commits December 23, 2025 18:54

fix zigbee new capabilities unit tests

3f0d506

Add table load check

0d7fe54

CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials capability #2416

Are you sure you want to change the base?

CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials capability #2416

Conversation

pegor-karoglanian commented Sep 19, 2025

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

CLAassistant commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pegor-karoglanian commented Dec 10, 2025

Uh oh!

Uh oh!

greens Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greens Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pegor-karoglanian Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading