Conversation
| !insertmacro dlFile "${SVRServerURLType}" "SlimeVR Server" "${SVRServerVersion}" "${SVRServerDLURL}" "${SVRServerDLFileZip}" | ||
| !insertmacro unzipFile "SlimeVR Server" "${SVRServerVersion}" "${SLIMETEMP}\${SVRServerDLFileZip}" "${SLIMETEMP}\SlimeVR" | ||
|
|
||
| ${If} $SELECTED_INSTALLER_ACTION == "update" |
There was a problem hiding this comment.
On a update from non electron to electron what has to be deleted?
There was a problem hiding this comment.
slimevr-ui is really old and prob does not exists anymore
the only gui file used to be slimevr.exe which is replaced by the unzip of electron.
|
|
||
| RMDir /r "$INSTDIR\Recordings" | ||
| RMdir /r "$INSTDIR\jre" | ||
| RMDir /r "$INSTDIR\logs" |
There was a problem hiding this comment.
hm not scope of this pr probably, but i see here, that we don't remove the
%appdata%\dev.slimevr.SlimeVR and %localappdata%\dev.slimevr.SlimeVR
(at least the directory EBWebView and File .cookies)
I think it would be a good idea to clean that up on uninstall
There was a problem hiding this comment.
i think reason was to keep user config. but ig we could delete these too. if you unintall it should be expected that your settings will be cleared
There was a problem hiding this comment.
As of discusion in Discord:
leave the config in appdata, but remove the localappdata and for future also the electron
loucass003
force-pushed
the
llelievr/electron-installer
branch
from
3e0ab0d to
40c891d
Compare
2 participants
No description provided.