Skip to content

Implement converting PageContent's into HTML#231

Merged
KnightMiner merged 63 commits intoSlimeKnights:nobuild-html-bookfrom
paypur:1.20_wiki
Apr 18, 2026
Merged

Implement converting PageContent's into HTML#231
KnightMiner merged 63 commits intoSlimeKnights:nobuild-html-bookfrom
paypur:1.20_wiki

Conversation

@paypur
Copy link
Copy Markdown
Contributor

@paypur paypur commented Jul 16, 2025

@KnightMiner
Copy link
Copy Markdown
Member

Its also worth asking, do you plan to implement tooltips or not? Its fine without tooltip; text + links is better than nothing. But want to know so I know how to review this.

Comment thread src/main/java/slimeknights/mantle/command/client/BookCommand.java
Comment thread src/main/java/slimeknights/mantle/client/book/IHTML.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/screen/book/BookScreen.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/screen/book/BookScreen.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/screen/book/TextDataRenderer.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/book/HTMLUtils.java
Comment thread src/main/java/slimeknights/mantle/client/book/HTMLUtils.java Outdated
Comment thread gradle.properties Outdated
@paypur
Copy link
Copy Markdown
Contributor Author

paypur commented Jul 16, 2025

I'll try but not in this pr

paypur added 2 commits July 16, 2025 18:32
Removed unnecessary spans and colors

Took 3 hours 23 minutes
Comment thread src/main/java/slimeknights/mantle/client/book/data/content/ContentTextImage.java Outdated
Comment thread src/main/java/slimeknights/mantle/command/client/BookCommand.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/book/data/element/TextData.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/book/IHTML.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/book/HTMLUtils.java Outdated
@paypur
Copy link
Copy Markdown
Contributor Author

paypur commented Jan 24, 2026

Should be everything, but I'll need to test that I didn't break anything. As for the html classes you wrote, I think that would be better for a separate pr after this is merged, so its easier to compare before and after migrating.

Comment thread src/main/java/slimeknights/mantle/client/screen/book/BookScreen.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/book/data/element/TextComponentData.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/book/data/element/TextData.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/screen/book/BookScreen.java Outdated
Comment thread src/main/java/slimeknights/mantle/client/book/data/element/TextData.java Outdated
@paypur
Copy link
Copy Markdown
Contributor Author

paypur commented Feb 8, 2026

I'm still working on this, I've just been a little busy

@KnightMiner
Copy link
Copy Markdown
Member

KnightMiner commented Feb 9, 2026

One thought from SlimeKnights/TinkersConstruct#5577 is we may want to swap the bullet point from space to \u00a0, which would break your bullet point detection. Easiest thing to do is probably to check for either string, and use the \u00a0 version as the public string constant. Will let us gradually switch books to it.

@paypur paypur requested a review from KnightMiner March 21, 2026 06:21
@KnightMiner KnightMiner changed the base branch from 1.20 to nobuild-html-book April 18, 2026 22:14
@KnightMiner KnightMiner merged commit 43639ba into SlimeKnights:nobuild-html-book Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants