Skip to content

Bump minSdk from 28 to 29#2719

Merged
RichSutherSky merged 1 commit into
mainfrom
donburi/DON-3288-backpack-bump-min-sdk-from-28-to-29
Jun 26, 2026
Merged

Bump minSdk from 28 to 29#2719
RichSutherSky merged 1 commit into
mainfrom
donburi/DON-3288-backpack-bump-min-sdk-from-28-to-29

Conversation

@RichSutherSky

Copy link
Copy Markdown
Contributor

Remember to include the following changes:

  • Component README.md
  • Tests

If you are curious about how we review, please read through the code review guidelines

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Raises the Android minimum supported API level from 28 to 29 and updates related configuration/comments to reflect the new baseline.

Changes:

  • Bump minSdk from 28 → 29 in shared SDK version constants.
  • Bump minSdk from 28 → 29 in the Gradle Android configuration.
  • Update a lint configuration comment to align with the new minSdk context.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
lint.xml Updates a comment describing why a lint check is ignored.
build-logic/conventions/src/main/kotlin/SdkVersions.kt Raises MIN_SDK constant to 29.
android-configuration.gradle.kts Raises defaultConfig.minSdk to 29.


defaultConfig {
minSdk = 28
minSdk = 29
Comment thread lint.xml
<issue id="GradleDependency" severity="ignore" />

<!-- As our minSdk is 28 this is not relevant -->
<!-- As our minSdk is below API 30 this is not relevant -->
@RichSutherSky RichSutherSky added the skip-changelog Used for any changes that shouldn't be referrenced in the changelog label Jun 26, 2026
@RichSutherSky RichSutherSky force-pushed the donburi/DON-3288-backpack-bump-min-sdk-from-28-to-29 branch from d4ceff2 to 6875cae Compare June 26, 2026 09:20
@skyscanner-backpack-bot

Copy link
Copy Markdown
Contributor
Warnings
⚠️ One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️

One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.

⚠️

One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 6875cae

@RichSutherSky RichSutherSky enabled auto-merge (squash) June 26, 2026 09:27
@RichSutherSky RichSutherSky merged commit 5ef8794 into main Jun 26, 2026
19 checks passed
@RichSutherSky RichSutherSky deleted the donburi/DON-3288-backpack-bump-min-sdk-from-28-to-29 branch June 26, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Used for any changes that shouldn't be referrenced in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants