Bump minSdk from 28 to 29#2719
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Raises the Android minimum supported API level from 28 to 29 and updates related configuration/comments to reflect the new baseline.
Changes:
- Bump
minSdkfrom 28 → 29 in shared SDK version constants. - Bump
minSdkfrom 28 → 29 in the Gradle Android configuration. - Update a lint configuration comment to align with the new minSdk context.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lint.xml | Updates a comment describing why a lint check is ignored. |
| build-logic/conventions/src/main/kotlin/SdkVersions.kt | Raises MIN_SDK constant to 29. |
| android-configuration.gradle.kts | Raises defaultConfig.minSdk to 29. |
|
|
||
| defaultConfig { | ||
| minSdk = 28 | ||
| minSdk = 29 |
| <issue id="GradleDependency" severity="ignore" /> | ||
|
|
||
| <!-- As our minSdk is 28 this is not relevant --> | ||
| <!-- As our minSdk is below API 30 this is not relevant --> |
d4ceff2 to
6875cae
Compare
Generated by 🚫 Danger Kotlin against 6875cae |
Remember to include the following changes:
README.mdIf you are curious about how we review, please read through the code review guidelines