Draft
Conversation
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 014bde5 |
| fmdeps/BRiCk/ | main | 4ce7328 |
| fmdeps/auto/ | main | f336ece |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | 5a39ba2 |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | d5ff6c5 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | a33abee |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 6c7fffd |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122612.2 | 122612.2 | +0.0 | total |
| +0.00% | 22464.3 | 22464.3 | +0.0 | ├ translation units |
| +0.00% | 100147.9 | 100147.9 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122612.2 | 122612.2 | +0.0 | total |
| +0.00% | 22464.3 | 22464.3 | +0.0 | ├ translation units |
| +0.00% | 100147.9 | 100147.9 | +0.0 | └ proofs and tests |
pgiarrusso-sl
force-pushed
the
paolo/iter_path_args-tweak
branch
from
690a0ca to
2d95179
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 014bde5 |
| fmdeps/BRiCk/ | main | 4ce7328 |
| fmdeps/auto/ | main | f336ece |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | 5a39ba2 |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | d5ff6c5 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 441bdce |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 6c7fffd |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122612.2 | 122612.2 | -0.0 | total |
| -0.00% | 22464.3 | 22464.3 | -0.0 | ├ translation units |
| +0.00% | 100147.9 | 100147.9 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122612.2 | 122612.2 | -0.0 | total |
| -0.00% | 22464.3 | 22464.3 | -0.0 | ├ translation units |
| +0.00% | 100147.9 | 100147.9 | +0.0 | └ proofs and tests |
rlepigre-skylabs-ai
approved these changes
Feb 23, 2026
Contributor
|
Actually, I don't think we have any test coverage for this. I couldn't find a good approach for testing, so this was tested manually. You might want to confirm that things are not broken before merging this @pgiarrusso-sl. One way to test this is with try:
rocq_args_for(
"../../BRiCk/ltac2-logger/theories/logger.v",
cwd=Path("../../auto"),
plugins=[DuneRocqPlugin(opam_pkg="rocq-goal-to-json", entry_points=["basic/theories/goal_util.v"])]
)
except DuneRocqPluginNotFound as e:
print(e) |
Contributor
Author
|
In a meeting, Rodolphe confirmed this is right but the "bug" gets usually hidden. |
Co-authored-by: Rodolphe Lepigre <rodolphe.lepigre@skylabs-ai.com>
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 57d9592 |
| fmdeps/BRiCk/ | main | f324984 |
| fmdeps/auto/ | main | b5395a0 |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | 5a39ba2 |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | d5ff6c5 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 87bc3c1 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 6c7fffd |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122626.7 | 122626.6 | -0.0 | total |
| -0.00% | 22464.3 | 22464.3 | -0.0 | ├ translation units |
| +0.00% | 100162.3 | 100162.3 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122626.7 | 122626.6 | -0.0 | total |
| -0.00% | 22464.3 | 22464.3 | -0.0 | ├ translation units |
| +0.00% | 100162.3 | 100162.3 | +0.0 | └ proofs and tests |
Comment on lines
132
to
+144
| def _iter_path_args( | ||
| args: list[str], | ||
| ) -> Iterator[tuple[Literal["I"], str] | tuple[Literal["Q"], str, str]]: | ||
| nb_args = len(args) | ||
| for i in range(nb_args): | ||
| while i < nb_args: | ||
| opt = args[i] | ||
| if opt == "-I" and i < nb_args - 1: | ||
| yield ("I", args[i + 1]) | ||
| if (opt == "-Q" or opt == "-R") and i < nb_args - 2: | ||
| yield ("Q", args[i + 1], args[i + 2]) | ||
| i += 1 | ||
| if opt == "-I" and i < nb_args: | ||
| yield ("I", args[i]) | ||
| i += 1 | ||
| if (opt == "-Q" or opt == "-R") and i < nb_args - 1: | ||
| yield ("Q", args[i], args[i + 1]) | ||
| i += 2 |
Contributor
There was a problem hiding this comment.
This might also work. If you manifest the iterator, then you can explicitly use next on it and advance it within the loop. I will note that this will raise an exception if the arguments are incorrect.
Suggested change
| i += 2 | |
| def _iter_path_args( | |
| args: list[str], | |
| ) -> Iterator[tuple[Literal["I"], str] | tuple[Literal["Q"], str, str]]: | |
| it = iter(args) | |
| for opt in it: | |
| if opt == '-I': | |
| yield ("I", next(it)) | |
| elif opt in ["-Q", "-R"]: | |
| yield ("Q", next(it), next(it)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reviewing this code, and naively this change seems necessary — hence the PR.
Tests pass, so test coverage is insufficient.
@rlepigre-skylabs-ai can tell if the change is appropriate.