fix(rocq-pipeline): use futures for parallel_runner so worker results are reported immediately#221
Merged
jhaag-skylabs-ai merged 3 commits intomainfrom Feb 26, 2026
Conversation
… are reported immediately
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 2cb75e1 |
| fmdeps/BRiCk/ | main | f938caa |
| fmdeps/auto/ | main | c7cb50c |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | bd74d48 |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | d5ff6c5 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 78623c8 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 6c7fffd |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122620.9 | 122620.9 | -0.0 | total |
| -0.00% | 22464.4 | 22464.4 | -0.0 | ├ translation units |
| +0.00% | 100156.5 | 100156.5 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122620.9 | 122620.9 | -0.0 | total |
| -0.00% | 22464.4 | 22464.4 | -0.0 | ├ translation units |
| +0.00% | 100156.5 | 100156.5 | +0.0 | └ proofs and tests |
Contributor
gmalecha-at-skylabs
left a comment
gmalecha-at-skylabs
left a comment
There was a problem hiding this comment.
Im in favor of the change once you fix the issue.
…in order, and properly handle future cancellation/exceptions
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 2cb75e1 |
| fmdeps/BRiCk/ | main | f938caa |
| fmdeps/auto/ | main | c7cb50c |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | bd74d48 |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | d5ff6c5 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 78623c8 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 6c7fffd |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122620.9 | 122620.9 | +0.0 | total |
| +0.00% | 22464.4 | 22464.4 | +0.0 | ├ translation units |
| +0.00% | 100156.5 | 100156.5 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122620.9 | 122620.9 | +0.0 | total |
| +0.00% | 22464.4 | 22464.4 | +0.0 | ├ translation units |
| +0.00% | 100156.5 | 100156.5 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 57d9592 |
| fmdeps/BRiCk/ | main | f324984 |
| fmdeps/auto/ | main | b5395a0 |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | 5a39ba2 |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | d5ff6c5 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 37f7734 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 6c7fffd |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122626.6 | 122626.6 | -0.0 | total |
| -0.00% | 22464.3 | 22464.3 | -0.0 | ├ translation units |
| +0.00% | 100162.3 | 100162.3 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122626.6 | 122626.6 | -0.0 | total |
| -0.00% | 22464.3 | 22464.3 | -0.0 | ├ translation units |
| +0.00% | 100162.3 | 100162.3 | +0.0 | └ proofs and tests |
jhaag-skylabs-ai
deleted the
rocq-pipeline/task-runner/use-futures-for-parallel-tasks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The previous implementation of
parallel_runnerusedThreadPoolExecutor.map. This yields results in the order they are processed, blocking until the next result is available. This means that if a long-running task is "next" and subsequent/shorter tasks conclude in parallel, their results will not be processed immediately.The effect is that when running agent pipelines we often observe print-statements indicating task success/failure before the overall status/progress bar is updated.
Change
In
rocq_pipeline/util.py#parallel_runner:ThreadPoolExecutor.submitto create futures for each task up-frontconcurrent.futures.as_completedto eagerly process futures in the order that results become available