Added tag for use of deprecated tactics (currently only verify_spec')…#182
Open
LennartATSkylabsAI wants to merge 3 commits intomainfrom
Open
Added tag for use of deprecated tactics (currently only verify_spec')…#182LennartATSkylabsAI wants to merge 3 commits intomainfrom
LennartATSkylabsAI wants to merge 3 commits intomainfrom
Conversation
… and included the 'self.name' field in Task.get_id()
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 9259c2e |
| fmdeps/BRiCk/ | main | 6b2f050 |
| fmdeps/auto/ | main | ac6479d |
| fmdeps/auto-docs/ | main | e83c1ad |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | 37b86fb |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | 33d6ba2 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | e97f125 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | b1f795a |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 1782827 |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 63f9a19 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122778.5 | 122778.5 | -0.0 | total |
| -0.00% | 22467.8 | 22467.8 | -0.0 | ├ translation units |
| +0.00% | 100310.7 | 100310.7 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122778.5 | 122778.5 | -0.0 | total |
| -0.00% | 22467.8 | 22467.8 | -0.0 | ├ translation units |
| +0.00% | 100310.7 | 100310.7 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 9259c2e |
| fmdeps/BRiCk/ | main | 6b2f050 |
| fmdeps/auto/ | main | ac6479d |
| fmdeps/auto-docs/ | main | e83c1ad |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | 37b86fb |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | 33d6ba2 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | e97f125 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | b1f795a |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 1782827 |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 63f9a19 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122778.5 | 122778.5 | -0.0 | total |
| -0.00% | 22467.8 | 22467.8 | -0.0 | ├ translation units |
| +0.00% | 100310.7 | 100310.7 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122778.5 | 122778.5 | -0.0 | total |
| -0.00% | 22467.8 | 22467.8 | -0.0 | ├ translation units |
| +0.00% | 100310.7 | 100310.7 | +0.0 | └ proofs and tests |
Contributor
Author
|
CI is green but I suspect the change in Task.get_id() may break some downstream code that |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | 9259c2e |
| fmdeps/BRiCk/ | main | 6b2f050 |
| fmdeps/auto/ | main | ac6479d |
| fmdeps/auto-docs/ | main | e83c1ad |
| bluerock/NOVA/ | skylabs-proof | 927947d |
| bluerock/bhv/ | skylabs-main | 37b86fb |
| fmdeps/brick-libcpp/ | main | 53842f7 |
| fmdeps/ci/ | main | 33d6ba2 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | e97f125 |
| fmdeps/fm-tools/ | main | 46ed5a6 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | b1f795a |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 1782827 |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 63f9a19 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122778.5 | 122778.5 | -0.0 | total |
| -0.00% | 22467.8 | 22467.8 | -0.0 | ├ translation units |
| +0.00% | 100310.7 | 100310.7 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122778.5 | 122778.5 | -0.0 | total |
| -0.00% | 22467.8 | 22467.8 | -0.0 | ├ translation units |
| +0.00% | 100310.7 | 100310.7 | +0.0 | └ proofs and tests |
gmalecha-at-skylabs
requested changes
Feb 13, 2026
Contributor
gmalecha-at-skylabs
left a comment
gmalecha-at-skylabs
left a comment
There was a problem hiding this comment.
The changes around tagging is fine, but I am less certain about the name handling.
|
|
||
| def make_task( | ||
| file_path: str, | ||
| name: str | None, |
Contributor
There was a problem hiding this comment.
Since this is used for testing, I think that we should drop this argument. If we want to keep it, we should put it at the end as a keyword-only argument with a default.
Comment on lines
77
to
+79
| if self.name is not None: | ||
| return self.name | ||
| return f"{self.file}#{self.locator}" | ||
| return f"{self.file}#{str(self.name)}#{self.locator}" |
Contributor
There was a problem hiding this comment.
This this point, we know that self.name is None, so why are we including it in the string name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… and included the 'self.name' field in Task.get_id()